Commit Graph
111 Commits
Author SHA1 Message Date
Kandera 648321e121 Core/Spelld: fix target selection for ground based aoe spells. use the center of the cast (dynamic object) instead of the caster for checking los 2012-05-15 13:26:15 -04:00
Kandera 6c15bee884 Core/AI: fix the call to help handler to use distance from the npc and not the victim of the npc. (thx shauren) 2012-05-08 09:17:04 -04:00
Shauren 4818c70dcb Core/Spells: Removed unneeded phase check from spell casts, its already done in canSeeOrDetect for spells that need it. Probably more phase checks are not needed either 2012-04-18 22:27:40 +02:00
faramir118 d3c9817c60 make some dtors virtual
this will prevent potential for future memory leaks
2012-04-11 19:58:53 +02:00
kaelima 49e24e2dfb Core/Cleanup:
Mostly if(.. -> if (.. and for(.. -> for (..
but also some miscellaneous cleanup
2012-04-08 23:59:52 +02:00
kaelima 72d3e856de Core/Grid: revert f9caf79b16 - led to some unexpected behavior. 2012-03-29 02:56:18 +02:00
kaelima f9caf79b16 Core/Grid: Fix crashes when closing up to the edge of a map.
Closes #5085
2012-03-28 02:38:16 +02:00
Shauren 76397cf931 Core/Grids: Removed unsafe substraction, fixes possible freezes 2012-03-28 01:26:45 +02:00
Shauren ae0511a2a4 Core/Spells: Fix DynamicObject AoE effects for invisible targets e.g Flare. Original patch by Elron
Closes #5898
2012-03-28 01:13:58 +02:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
thomas33 cae662d191 cleanup 2012-03-13 15:48:18 +01:00
thomas33 0532afed90 more cleanup 2012-03-13 14:53:36 +01:00
kaelima 6217583627 Core/Map:
- Remove mysterious restriction in visibilityhelper for gameobjects
- Some cleanup in CheckAreaExploreAndOutdoor() and GridDefines.h
- Set nocreate for cells visited in Map::VisitNearbyCellsOf
2012-03-12 04:33:24 +01:00
Spp 1e246cb66c Fix build (gcc) and fix warnings 2012-02-22 09:15:57 +01:00
QAston f09b5a6bea Core/Db/Conditions:
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required

Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
Kandera c517806a23 Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts. 2012-02-18 12:12:49 +01:00
Shauren 65d269f6de Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
kiper 8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
QAston 15bd8f3cd5 Core/Spells: Fix logic in AnyDeadUnitSpellTargetInRangeCheck - spells using this should now correctly check target requirements. This is an alternative fix to #4112. 2011-12-24 08:40:30 +01:00
megamage ce0dfa88a6 Revert "Temp fix for *nix build."
It builds in *nix without this patch.

This reverts commit e84fffe588.
2011-12-22 10:15:17 -05:00
megamage e84fffe588 Temp fix for *nix build. 2011-12-22 08:57:16 -05:00
megamage 36bfce08b4 Try to fix build in Linux. 2011-12-21 08:55:54 -05:00
megamage 8cf2062c1f Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while). 2011-12-20 17:07:09 -05:00
megamage 6a648c01a4 Some clean up of grid system. 2011-12-07 13:02:44 -05:00
megamage 077a2194ba Fix another place where corpse is added twice to a grid. 2011-11-11 18:57:50 -05:00
megamage f47c0e661c Add some comments for the previous crash fix. Thanks to Amit86. 2011-11-11 14:20:49 -05:00
megamage 9e3b4fe409 Cleanup before deleting objects when unloading grid. Fix #3922. 2011-11-11 14:11:58 -05:00
megamage 31a88d4fe5 Fix the crash when removing object from an unloaded grid. Object should always be unlinked from grid no matter if the grid is loaded. 2011-11-10 17:31:45 -05:00
megamage 23b3f16f3a Add some ASSERT in add/remove obj to/from grid. 2011-11-10 10:18:32 -05:00
Bootz d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
kaelima f2000f3fb5 Core/Misc: Some minor cleanups
Fixed SQL added in prev commit.
2011-10-24 23:33:17 +01:00
megamage 91f56c181c More cleanup of grid system. 2011-10-22 10:01:29 -04:00
megamage 80a18b9e56 Some cleanup of grid system. 2011-10-22 09:36:05 -04:00
kaelima be0b2fcf97 Core/Grid:
- Simplified CellArea calculation (Original author: SilverIce)

- Removed unused code in Cell class (Original author: SilverIce)

- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
megamage 7231ab959f Clean up grid system. Get rid of GridLoader. This patch should not change any logic, except the incorrect calculation of the number of loaded corpse (which only affects log). 2011-10-18 14:31:34 -04:00
megamage e27ef59548 Clean up grid system: allow directly creating Cell from x, y. 2011-10-18 11:18:49 -04:00
megamage e0d933fed8 Use method IsCoordValid() to replace explicit checks. 2011-10-18 11:05:32 -04:00
megamage c29ff41001 Rename some classes in grid system.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
Spp 805e14a463 Core/Grid: Replaced ambiguous operator overloads with functions (Makes it clear to read) 2011-10-18 11:42:40 +02:00
Fredi Machado 97142102e0 Core/Misc: Added 'f' after float values 2011-10-17 07:38:27 -03:00
megamage 11bb9bfdb3 Fix compile error in gcc. 2011-10-11 08:56:44 -04:00
megamage 76c9c30c2b Merge pull request #3399 from megamage/master
Fix the relocation of creatures across cells. Try to fix #3054.
2011-10-10 13:12:15 -07:00
megamage f9fc12650b Merge pull request #3259 from Souler/pull
Traps and Basic Campfire ignoring unattackable flags.
2011-10-08 13:36:05 -07:00
Bootz 5b4c7783c2 REPO: Code-style clean-ups
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00
megamage eb8cbae0d5 Fix the relocation of creatures across cells. Try to fix #3054. 2011-10-07 17:36:23 -04:00
Bootz 81c0a3a847 REPO: code-style clean-up
* Fixed pPlayer->player
* Fixed pCreature->creature

~DevNote: codestyle for Player should be (*player), not *plr or *p...
same goes for Creatures (*creature)... more cleaning needed.
We've way too many codestyles happening here.
2011-10-07 11:08:09 -05:00
Bootz f1ccb83dc0 REPO: Code-style change
* Fixed pUnit-unit
2011-10-07 10:48:56 -05:00
Nay 0f7d9e4837 Core/SAI: Fix an issue where SAI was ignoring civilian and passive unit flags
Closes #2526
Disclaimer: This was not thoroughly tested; report any issue caused by this change.
2011-10-01 16:29:23 +01:00