Commit Graph
18455 Commits
Author SHA1 Message Date
Treeston a69a061d76 Battleground/Arena: Properly check RBAC arena join permission before allowing queue. Closes #23000.
(cherry picked from commit af082664ca8ff76cc8ef1947d6ce76310d65b58b)
2021-12-15 23:31:31 +01:00
Treeston b4b581de1b Scripts/Commands: .account ban no longer fails if an account containing the specified account name is already banned (f.ex. attempting to ban 'test' if 'test2' is already banned) - closes #22990
(cherry picked from commit daf423a6c3c0fdd13e421f02ccd791103f7bdd5b)
2021-12-15 22:48:03 +01:00
Treeston b8c7260bfd typo fix, duplicate assignment
(cherry picked from commit 7d6896b54141c32c51f49f2c3fcd58cd986f0e02)
2021-12-15 22:41:58 +01:00
Treeston 6de4c3cd72 Entities/GO: FindNearestGameObject no longer incorrectly returns despawned gameobjects. Closes #23262.
(cherry picked from commit 4423ca99e7f8c38ff83196134038a7790313ed7a)
2021-12-15 22:40:39 +01:00
Killyana 4378ad98ab DB/Quest: Seeds of the Blacksouled Keepers
(cherry picked from commit 42abf69a27058251b7dd59a59c1f059f834431e4)
2021-12-15 21:51:07 +01:00
ccrs 16bbc015e7 Core/Weather: 6eecb68 followup
missing IntervalTimer::Update call

(cherry picked from commit 965ec9a57180062aa8dad3b929146c7692186262)
2021-12-15 00:17:33 +01:00
Giacomo Pozzoni ebe436d2c2 Core/ChatCommands: Fix .wp reload crash
(cherry picked from commit e4c2bb4f1411f2db724a7cfcdc014013a63b37a5)
2021-12-15 00:17:32 +01:00
Wyrserth 755a83f634 Core/Quest: remove arbitrary error logs related to breadcrumb quest chaining.
There are complex cases where breadcrumb quests are mutually exclusive with other breadcrumbs leading to other quests, chaining them shouldn't generate log errors.

(cherry picked from commit e6080116f9acb41b1c3d26468a679ff7e4b7c106)
2021-12-15 00:17:32 +01:00
Treeston 2799cdc522 Scripts/World: Rewrite air force trigger bots script, add hostility check along the way. Closes #23307.
(cherry picked from commit 0ae2afe307595463df8f4a16fdd1ee9740a11c9e)
2021-12-15 00:17:32 +01:00
ccrs 6ae0a6ba22 Core/Movement: add missing parenthesis on MotionMaster::Size
pretty sure this can cause unexpected behaviour

(cherry picked from commit bec52dba3d7e4acb0b78c6a1093fe33da8205781)
2021-12-15 00:17:32 +01:00
Treeston fc9908d163 warning fix f2cd721 follow-up
(cherry picked from commit be96d8242c0b8abf909862a577d04a9f8e18560a)
2021-12-15 00:17:32 +01:00
Treeston 925aaecbc0 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements. Fixes #226. Yes, you read that issue tag right.
(cherry picked from commit a1fd404b64fe46925cf5ab3e3af267ce9ba1badd)
2021-12-15 00:17:32 +01:00
Treeston 9491650401 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026.
(cherry picked from commit f2cd721d5358f7febf36dc757f5e3e9693a6a7b6)
2021-12-15 00:17:32 +01:00
Ianislav Vasilev fa9683fc68 Scripts/Blood Furnace: Broggok improvements (#23300)
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.

(cherry picked from commit c71e36acaea9c04e63dcba9a39b5a6a76e3cac75)
2021-12-15 00:17:32 +01:00
Treeston fdb43e41a8 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348.
(cherry picked from commit a3c35262692e2f059785c22f92fce39ffe4dc6ac)
2021-12-15 00:17:32 +01:00
Sorikoff a947a0e85e Scripts/Spells: Brittle Armor & Mercurial Shield (#23576)
(cherry picked from commit a64d7df6623d90c529fab76dc6b41e2db5a3abd4)
2021-12-15 00:17:32 +01:00
ForesterDev 61cc88731c Scripts/Commands: update .wp commands to use orientation field from DB (PR #23566)
Closes #23330

(cherry picked from commit e71773140c8efbea4abe612a71d4a65f041d450c)
2021-12-15 00:17:13 +01:00
Treeston a5d8807af8 Entities/Player: Properly restore PvP-enabled state on login
(cherry picked from commit 671052575a36624b06379ee5e13a7fea26870194)
2021-12-14 23:31:56 +01:00
Aokromes 3ad5bc1e15 Core/Misc: More coding standards (#23519)
* Core/Misc: More coding standards

* revert part

* "void  " or more to "void "

* fix? reject

* remove more double whitespaces

* remove more double whitespaces

* more standards

* more coding standards

* More standards

* more coding

* more coding standards

* more coding standards

* And more standards

(cherry picked from commit 574a7c8d3d5f5a5660295deb70e905cf4dd756c4)
2021-12-14 23:04:29 +01:00
Treeston 2532de6acb Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications:
- .npc respawn no longer causes stupid things to happen (Fixes #23014)
- ::DeleteFromDB methods on Creature and GameObject rewritten to be as sensible as such a colossally stupid method can ever be. They're static now.
- .npc delete and .gobj delete ported to new argument handling, and rewritten as per above. They can no longer crash the server when used in instances, too. Yay for that.
- Adjusted various dusty cobwebbed hacks around the core (why does waypoint visualization use permanent spawns *shudder*) to still work too.

(cherry picked from commit 84b7b2e08ea55575cbe62d795383d4a5341ffd4d)
2021-12-14 22:42:22 +01:00
ccrs 8be3d33eae Build: fix linking error
/home/circleci/project/src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp:50:9: fatal error: use of undeclared identifier 'AddFlag'
        AddFlag(MOVEMENTGENERATOR_FLAG_TIMED_PAUSED);
        ^

(cherry picked from commit ec1a77bca20487f86765620485db9b13bb03aee8)
2021-12-14 22:24:34 +01:00
Treeston 2225cb1201 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output.
(cherry picked from commit ded18a2690063991d5440df7d3e5d526b884ec16)
2021-12-14 22:24:24 +01:00
ccrs f21599dc5d Core/Movement: handle Resume/Pause on RandomMovementGenerator
(cherry picked from commit b8c0aeaf14dfabc9940203aec21ef29111e755cc)
2021-12-14 22:19:40 +01:00
ccrs ff11e95071 Core/Unit: f869c49 followup
Movement Pause/Clear is already handled in Unit::SetCharmedBy and Unit::RemoveCharmedBy, respectively

TODO: missing PAUSE handling in RandomMovementGenerator
(cherry picked from commit 4fa3c04b7263c0038b96e50c29f8ba52a4802995)
2021-12-14 22:19:13 +01:00
Wyrserth 24c07367f1 Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases.
Closes #21731 and #22368.

(cherry picked from commit f869c4969ebd573da2742dcee0dfbe688e7896e0)
2021-12-14 22:19:01 +01:00
Wyrserth 004602f3e4 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests.
Closes #23572.

(cherry picked from commit 9f6d3e93f95ea126512e5eb52e46dbaefccf54d6)
2021-12-14 22:17:47 +01:00
Shauren d249a2a98a Warning fixes 2021-12-14 22:15:04 +01:00
Wyrserth 569660a933 Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.

(cherry picked from commit 37862942ce61ceffe5440d67efe7db553fa22f9b)
2021-12-14 22:13:56 +01:00
Wyrserth 2efb6b6187 Core/Spell: don't send duration for auras caused by dynobjects.
(cherry picked from commit 1d1b77c3f0c7625228f328cf894610c14a54c308)
2021-12-14 22:03:20 +01:00
Wyrserth 756325bc84 Script/BlackrockDepths: randomize timers for Ironhand Guardian's spell Gout of Flame.
(cherry picked from commit 6ef1b3e6c6d51635dc4ba4cf4f9fb9565d390807)
2021-12-14 22:02:52 +01:00
Wyrserth 55611104be Core/Spell: do not allow auras from dynamic objects to stack if they come from the same spell cast by the same caster.
(cherry picked from commit b87350807db65e8e819cfc562749c22441eeb5ab)
2021-12-14 22:02:25 +01:00
Wyrserth 2c55730a01 Misc/Config: set decay timer for unlooted normal creatures to 5 minutes.
Now that respawns do not care about the previous corpse's state, there's no reason to force a very frustrating faster despawn.

(cherry picked from commit 1bdbede7e0e24ed3c55787a63c8d67db539cee35)
2021-12-14 22:00:53 +01:00
Shauren 776298207a Core/Entities: Regenerate updatefields 2021-12-14 21:26:44 +01:00
Martin Topholm dc0728b9a0 Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816)
(cherry picked from commit 4529a94e0d093fb01c6ae4a98dade46ce75f82a9)
2021-12-14 21:19:01 +01:00
Wyrserth f31d8f7ffb Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad.
(cherry picked from commit 8fcc82138fee2bbea7b7f82d4b0475e4f53f100c)
2021-12-14 21:11:10 +01:00
Ovahlord 3fc20584bc Core/Creature: Reworked creature aggro radius calculation (#20615)
* Core/Creatures: rewrote creature aggro radius calculation
* Formulas are taken from WoW Wiki

(cherry picked from commit 980047763a685217e712f58b8713d48523d90ccb)
2021-12-14 21:09:11 +01:00
Wyrserth edf12fd6a1 Core/Conditions: allow spellclick conditions to properly work for aura apply/remove (#23527)
(cherry picked from commit 12e545f7e2247f91db3fd1e8e2f961982422a147)
2021-12-14 20:52:13 +01:00
ForesterDev 104ec7a81a Core/Unit: Implement more helper methods (#23555)
(cherry picked from commit c44fb37f74347e3b6d399c941716971503af4cf8)
2021-12-14 20:42:32 +01:00
Shauren dbb96e7717 Core/Spells: Fixed spells not doing damage after cherry-picking 83a9222c39 2021-12-14 16:13:41 +01:00
Giacomo Pozzoni c5173aca15 Core/Quest: Fix repeatable quest mark (#23338)
(cherry picked from commit 2cb4517303b217c57f52577a91184dc956a5c423)
2021-12-14 00:13:47 +01:00
Treeston 513b35ea2f Entities/Unit: Properly unset engaged flag for creates that cannot have a threat list on combat exit. Fixes #23518.
(cherry picked from commit f44539b64247ff626c53dc899c4ac3023bf9aa80)
2021-12-14 00:07:37 +01:00
Gildor e0f3255f90 Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy (#23559)
(cherry picked from commit a0a64b10b53e74c0cfaa518f196150c622e75bd2)
2021-12-14 00:07:14 +01:00
Treeston 096269349c Entities/Player: Fix an edge case where overlapping CCs could prevent player movement from being re-enabled. f6f1c48 follow-up.
(cherry picked from commit 4e767f1c7cd0cae6316982e38be66f560baafea5)
2021-12-14 00:06:51 +01:00
Treeston bba4696de7 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539.
(cherry picked from commit f6f1c48aa592ea10c99fd23f46e94934b2f0cef2)
2021-12-13 23:44:13 +01:00
Wyrserth 9cfa2ed71e Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd525218c0423421979177675004787707.
Closes #23337.

(cherry picked from commit a8b8a43b8d86f0039f4b4ac2c251d55ba3b6a4ed)
2021-12-13 00:42:20 +01:00
ForesterDev 27886c7f5d Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class

(cherry picked from commit b47bb59e2a3e42aff3793517ef94f51678b54905)
2021-12-13 00:42:20 +01:00
ccrs 4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00
Sorikoff b8d675eba7 Scripts/Spells: Dimensional Ripper - Everlook (#23547)
(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00
Wyrserth 819f8b1a2d Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music.
Closes #23548.

(cherry picked from commit 028d16a812bd3ff56f19da919ca1a35e7523fe8c)
2021-12-13 00:42:19 +01:00
Wyrserth ecce30a807 Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).

(cherry picked from commit c8289ada7f7d31a5e608c932db71ee6ec7fce0e6)
2021-12-13 00:42:19 +01:00