Commit Graph
141 Commits
Author SHA1 Message Date
Shauren 928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Spp 95daf7998f Core/Dungeon Finder: Fix a crash in rolecheck when a player is offline
Closes issue 5246

--HG--
branch : trunk
2010-12-23 21:11:11 +01:00
Spp b6724bea03 Core/Dungeon Finder: Fix crash in recursive calls while joining
closes issue 5162

--HG--
branch : trunk
2010-12-23 15:26:41 +01:00
Spp 067984ba9f Core/Dungeon Finder: Reset player Locked Dungeons after change level or bind to heroic instance
Note: Actual DF system is not supposed to select a dungeon you are already saved to (core does not support someone to have multiple saves on the same instance)

--HG--
branch : trunk
2010-12-23 06:06:24 +01:00
Spp 1f238d1700 Core/Dungeon Finder: Some cosmetic changes
- Drop pointer use in updateData struct
- Variable renaming
- Use of guid instead of group/player in rolecheck update

--HG--
branch : trunk
2010-12-23 06:06:19 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Spp 80a5cda77f Core/Dungeon Finder: Fix wrong join result when joining with random dungeons and there are disabled dungeons. If no disabled dungeons players also got the same problem if they have done an heroic dungeon today
Thanks to j4r0d for the help spotting the error and testing

--HG--
branch : trunk
2010-12-22 13:20:18 +01:00
leak 6115b0bd5f Removing ProgressBars as they are performing badly on startup.
[**************************************************] 100%
R.I.P

--HG--
branch : trunk
2010-12-22 00:12:03 +01:00
Spp a45a039e73 Fix typo in previous commit :S
--HG--
branch : trunk
2010-12-21 23:21:12 +01:00
Spp f33f51c287 Core/Dungeon Finder: Fix problems when joining queue
- Fix Rolechecks
- Fix incorrect dungeon stored when queued as individual:
  * Those that joined as random were only matching with others that joined random
  * Teleport location was incorrect.

Closes issue 5161
Updates issue 5162

--HG--
branch : trunk
2010-12-21 23:16:09 +01:00
Spp 0c44943cd2 Core/Dungeon Finder: Multiple changes
- Simplify lock status calculations by caching player locked dungeons
- Fix incorrect Lfg State loading for groups
- All reference variables that are supposed not to be modified are declared as const
- Use full group guids in rolechecks
- Add some debug msgs
- Fix some warnings

--HG--
branch : trunk
2010-12-21 22:33:17 +01:00
leak fd694cd232 Streamlining loading functions for server startup
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)

--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Spp 4671500172 Core/Dungeon Finder: Move all LFG data from Player and Group classes to internal LFG data classes.
--HG--
branch : trunk
2010-12-16 10:53:21 +01:00
Spp 451a6f40d4 Core/Dungeon Finder: Use full guid of players instead of lowguid
Note: This change is done in preparation of other changes that will come later.

--HG--
branch : trunk
2010-12-16 04:20:22 +01:00
Shauren 58a9b15443 Core: Fixes some warnings
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks

--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
2010-12-14 22:45:23 +01:00
Spp 89a33bbf61 Core/Dungeon Finder: Fix a crash in Join when there are no dungeons available for that group (And probably other random crashes that appear when having DF enabled)
Core/Dungeon Finder: Tab2spaces + remove trailing spaces in LFG* files.

Notes to self:
- assign NULL to a pointer parameter will not change the pointer value outside the scope of the function
- deleting a const_iterator can lead to mem corruption

--HG--
branch : trunk
2010-12-13 21:31:55 +01:00
Spp 865f35a637 Core/Dungeon Finder: Minor optimization in handler code
Note: LfgDungeonSet and LfgLockStatusMap were being used without using the existing typedef (to avoid including LFGMgr.h).
Now those functions use a struct as param that is forward declared so still LFGMgr.h is not needed and redefinition of LfgDungeonSet/LfgLockStatusMap is removed.

--HG--
branch : trunk
2010-12-13 21:28:36 +01:00
Spp 9815847511 Core/Dungeon Finder: Return a copy of cached dungeons set (to avoid being cleared later in code)
--HG--
branch : trunk
2010-12-13 21:28:33 +01:00
Spp a791df6415 Core/Dungeon Finder: Fix crash in Join
(trying to delete a const iterator)

Closes issue 5083

--HG--
branch : trunk
2010-12-10 14:58:45 +01:00
Spp be73926ab3 Core/Dungeon Finder: Fix incorrect Lfg state after multiple actions.
- Clear state after get out DF system
- Fix player not getting reward after finish a random dungeon
- Remove OnDisband Hook, it's already handled by OnRemoveMember

--HG--
branch : trunk
2010-12-09 19:13:11 +01:00
Spp 4914ca575b Core/Dungeon Finder: Fix a crash in Join
After a random dungeon is expanded to the corresponding dungeons and checked compatible dungeons of players joining. We have no dungeons and no lockmap.

This may only happen when a random dungeon is expanded to no dungeon. And this may be impossible to happen

Closes issue 5066

--HG--
branch : trunk
2010-12-09 14:25:48 +01:00
Spp 4537ba2766 Core/Dungeon Finder: Fix a possible crash in rolechecks when not success
--HG--
branch : trunk
2010-12-09 13:49:04 +01:00
Spp b434273ed8 Core/Dungeon Finder: Some optimizations
- Reduce core dependencies with LFGMgr
- Remove reduntant calculations in RoleCheck code
- Remove no longer needed functions
- Fix some packet data (Missing 0 when arrays were null)
- Add some debug msgs

closes issue 5042

--HG--
branch : trunk
2010-12-08 21:29:43 +01:00
Spp fbf525218b Core/Dungeon Finder: revert r14440b0b82 and fix it properly.
That msg was just for debugging purposed and its not needed anymore

--HG--
branch : trunk
2010-12-06 17:23:52 +01:00
Spp 2581c2f70f Core/Dungeon Finder: Fix console spam msg in Leave
--HG--
branch : trunk
2010-12-06 16:48:23 +01:00
Spp dfa1e9532b Core/Dungeon Finder: Use different queues for each team
--HG--
branch : trunk
2010-12-05 17:50:32 +01:00
Spp e621f5fe98 Core/Dungeon Finder: Code cleanup and minor optimizations
- Extend LfgState to keep control of the state of group and players using LFG
- Move scripts to its own class and initialize only if Dungeon finder is enabled
- Updated comments to doxygen format
- Use constructor initialization list
- All variables are declared in the inner most scope
- Fix some mem leaks
- Remove no longer needed code (Cleaner)
- Normalize handler function names

--HG--
branch : trunk
2010-12-05 17:50:26 +01:00
Spp 916c0f98df Core/Dungeon Finder: Fix members of premade group not being teleported to dungeon after a proposal success
--HG--
branch : trunk
2010-11-28 14:11:22 +01:00
Spp c2791232c3 Core/Dungeon Finder: After a proposal success only teleport new players
--HG--
branch : trunk
2010-11-28 00:43:21 +01:00
Spp 74ddff0c4e Core/Dungeon Finder: Fix role check algorithm (Some valid combinations were
being marked as invalid)

--HG--
branch : trunk
2010-11-27 22:41:49 +01:00
Spp c628685d59 Core/Dungeon Finder: Fix a crash in Join
Closes issue 4939

--HG--
branch : trunk
2010-11-26 17:16:21 +01:00
Spp 4ace88e909 Core/Dungeon Finder: Properly remove players from queue (or readd) after a proposal failed
--HG--
branch : trunk
2010-11-26 04:44:57 +01:00
Spp bbe955c5ab Core/Dungeon Finder: Multiple changes in Join function
- Reformat some code to make it easier to read
- Safe leave and rejoin queue when already queued and trying to rejoin to different dungeons (it was giving error earlier)
- Do not allow to select another dungeon while im the middle of a Lfg dungeon not completed (any dungeon selected is changed by current dungeon)
- Fix error that prevented groups to join another dungeon after completing the current lfg dungeon
Core/Dungeon Finder: Remove references to player from SendLfgUpdateParty and SendLfgUpdatePlayer handlers

--HG--
branch : trunk
2010-11-26 04:43:07 +01:00
Spp 90bf2d93ba Core/Dungeon Finder: Do not allow to join Queue if someone in party is using Battleground/Arena System
Core/Dungeon Finder: Minor code style fix

--HG--
branch : trunk
2010-11-24 15:37:03 +01:00
Spp 825dcbec53 Fix typo in previous commit
--HG--
branch : trunk
2010-11-23 15:57:43 +01:00
Spp 4dcdb396ad Core/Dungeon Finder: Fix role check algorithm (Some valid combinations were being marked as invalid)
--HG--
branch : trunk
2010-11-23 15:01:15 +01:00
Spp 9ec77e0b63 Core/Dungeon Finder: Add missing change from 653b579755 that prevented to join random dungeons
--HG--
branch : trunk
2010-11-22 18:36:08 +01:00
Spp f9d38be8c1 Core/Dungeon Finder: Fix a crash when trying to join raid browser as a group
--HG--
branch : trunk
2010-11-22 17:00:31 +01:00
Spp abb4f8f551 Core/Dungeon Finder: Fix visual bug that showed wrong needed roles after joined queue
--HG--
branch : trunk
2010-11-22 14:20:48 +01:00
Spp a5833f2307 Core/Dungeon Finder: Check lock status of dungeons when joining non-random dungeons (Fixes not checking if raid was closed for the selected difficulty)
Core/Dungeon Finder: Fix some memory leaks when Joining
Core/Dungeon Finder: Do not allow to join dungeon raid browser (Not supported yet)

--HG--
branch : trunk
2010-11-22 13:16:09 +01:00
Spp a7d262ce03 Core/Dungeon Finder: Do not allow to join if selected dungeons and raids
--HG--
branch : trunk
2010-11-22 12:28:06 +01:00
Spp a2ef7e18a1 Core/Dungeon Finder: Give rewards only to players that joined selecting random dungeon
--HG--
branch : trunk
2010-11-22 10:19:54 +01:00
Spp 6b6d992d55 Core/Dungeon Finder: Fix 'unknown' player names after group being formed and teleported to dungeon
Original Patch by danik
Closes issue 3846

--HG--
branch : trunk
2010-11-03 14:21:59 +01:00
Spp 1d7100b67f Core/Dungeon Finder: Fix a crash when someone leaves the group while a Rolecheck is active
--HG--
branch : trunk
2010-10-28 17:14:18 +02:00
Spp 3ac979e624 Core/Dungeon Finder: Fix a crash in UpdateProposal (added in 66a8af8214)
Closes issue 4564

--HG--
branch : trunk
2010-10-25 12:21:42 +02:00
Spp b1d759e79f Core/Dungeon Finder: Fix proposal window now being removed after a proposal success
--HG--
branch : trunk
2010-10-25 11:26:22 +02:00
Spp 18de18e7b9 Core/Dungeon Finder: Prevent a crash in Leave by checking Player or Group exist
--HG--
branch : trunk
2010-10-25 11:26:01 +02:00
Spp 4cd2431cd7 Core/Dungeon Finder: Redo Find algorithm to select one proposal (not all and later pick one)
--HG--
branch : trunk
2010-10-25 07:16:46 +02:00
Spp 131fb1580b Core/Dungeon Finder: Use internal Teleport function when teleporting someone out of the dungeon after a kick (To ensure all spells are being properly removed)
--HG--
branch : trunk
2010-10-19 12:39:24 +02:00