- Replace emote magic number by enum
- Added all missing defines from AnimationData.dbc. Minor corrections to existing ones. Standardized some naming and updated cpp files as needed.
- Correct a spell used in AQ
Closes#3787Closes#5095
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.
Technical changes:
* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.
--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:
- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time
Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.
Do not forget to re-run CMake before compiling.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
* Fixed codestyle "*c" -> "*creature"
* Removed SD2 Hieroglyphics
* Removed some hungarian notations
* Adjusted Some Alignments (cosmetic)
* Added spaces for "*"->" * " where needed (cosmetic)
* Fixed couple variableNames
DevNote: im sure VN's can be picked at and more found, but this was just a clean-up nothing more.
ToDo:
Alterac Valley -
Core/db: needs spawns in side the final bosses dens fixed and agro ranges corrected.. not blizzlike.
BRD -
Tomb of seven - Learning Smelt Dark Iron if tribute quest rewarded. Missing event.
blackrock_depths.cpp -
Need to rewrite the Jail Break support
Need to remove: npc_dughal_stormwing/npc_marshal_windsor/npc_marshal_reginald_windsor/npc_tobias_seecher if they are handled elsewhere, or get tehm fixed to uncomment them ;)
Malcrom