Commit Graph
1212 Commits
Author SHA1 Message Date
QAston 9bbb4ef583 Core/Spells: Use Unit::IsValidAttack/AssistTarget functions to validate spell explicit targets. 2011-09-16 22:17:49 +02:00
Shauren f356f65fa6 Core/Spell: Remove obsolete check, its already handled in a better way using SpellScript 2011-09-16 12:32:09 +02:00
Shauren 113080dace Core/Spells: Temporarily commented out SPELL_ATTR6_CAN_TARGET_UNTARGETABLE check, needs more research 2011-09-16 12:27:00 +02:00
Shauren 732e27f1e8 Core/Spells: Spells having the same effect types on multiple effects will now select them at the same time (except targets selected by entry) to ensure correct behavior with MaxAffectedTargets use 2011-09-16 11:40:53 +02:00
Shauren c93c27d056 Scripts/Icecrown Citadel:
* Mark of the Fallen Champion should be a debuff
* Fixed periodic damage taken from Twisted Nightmare on heroic difficulties of Valithria Dreamwalker encounter
2011-09-16 11:29:35 +02:00
Spp 6c943bfb08 Core: Cleanup in MiscHandler::SendAreaTriggerMessage and warning fixes 2011-09-16 10:53:24 +02:00
Shocker 7afb179185 Misc/Util: Add a template function for returning a random element from any container 2011-09-15 21:28:40 +03:00
Nay 791acfebac Core/Spells&GOs: Fix Ritual of Doom.
Thanks QAston and Shocker for helping.
Closes #2535
2011-09-15 17:52:35 +01:00
Spp af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
Shauren b7f6416ee3 Core/Spells: Fixed summoning to instances 2011-09-15 00:02:45 +02:00
Spp- 33ce07bdde Core: Minor cleanups (here and there)
- Fix warning
- Fix some typos
- Correct upper 'for' limit in LoadSkillLineAbilityMap
- Remove use of magic number in a query related to security levels
2011-09-13 14:15:35 +02:00
QAston 1d38ccaca6 Core/Spells: Remove redundant explicit target checks from Spell::cast 2011-09-11 22:42:29 +02:00
QAston 7c85617847 Core/Spells: Don't check cast requirements twice for instant cast spells. 2011-09-11 22:27:21 +02:00
Spp- 45af1238cf Conditions/DisableMgr: converted from singleton to namespace with free functions. 2011-09-09 14:27:23 +02:00
Spp- 327fe7c247 Core: Define helper functions to know if an account is Player, Moderator, GM, Admin or Console 2011-09-08 15:11:55 +02:00
Lopin d5cbc97373 Core/Spells: Changed targets of Lifebinder's Gift (search for entry instead of area ally). For conditions thanks Anubisss 2011-09-08 13:50:01 +02:00
kaelima 6078eebc45 Fix typo in 9d90c8245b and unintended change in b08900d033b51632e9adef8cb227a71a1061be5f. 2011-09-07 15:09:53 +02:00
kaelima 9d90c8245b Core/Spells: Deep freeze should do damage instead of freezing on targets with permanent stun immunity. 2011-09-07 00:19:40 +02:00
Nay 152f446c60 DB/BGs: Fix capturing of Snowball GY - AV
Counter-hack a hack with a hack. Closes #222
2011-09-06 21:20:14 +01:00
Nay dc123820ad Core/Spells: Correct a DBC mistake in Improved Stings (R2) 2011-09-06 18:12:09 +01:00
Spp- 30fb856ea3 Fix typo (Rename SPELL_AURA_PREVENT_RESSURECTION to SPELL_AURA_PREVENT_RESURRECTION) 2011-09-06 14:23:53 +02:00
QAston dad9d07045 Merge pull request #2920 from Chaplain/cleanup
Core/Auras: Improvements in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE handling: 
* Weapon specific case for MOD_DAMAGE_DONE_PCT shouldn't change PLAYER_FIELD_MOD_DAMAGE_DONE_PCT, because PLAYER_FIELD_MOD_DAMAGE_DONE_PCT applyed for _all_ damage that deal target.
* Fixed applying SPELL_AURA_MOD_DAMAGE_PERCENT_DONE for SpellDamageBonus.
2011-09-06 02:37:21 -07:00
QAston 94126e0369 Core/Spells: Fix some talents with incorrect target entries in dbcs. This is an alternative fix for #2848. Closes #2846 Closes #2848. 2011-09-06 11:21:40 +02:00
Chaplain abf9ac3159 Core/Auras: Weapon specific case for MOD_DAMAGE_DONE_PCT shouldn't change PLAYER_FIELD_MOD_DAMAGE_DONE_PCT, because PLAYER_FIELD_MOD_DAMAGE_DONE_PCT applyed for _all_ damage that deal target.
*fixed #2842
*updated comment
2011-09-05 19:43:24 +03:00
kaelima d295bc4d19 Core/Spells: Fix Sentry Totem's bind sight. 2011-09-05 15:48:41 +02:00
Shauren f13f32c972 Core/Achievements: Award normal mode achievements when instance was done on heroic mode 2011-09-05 15:21:37 +02:00
Spp- 3fac9914be Core: Code cleanup (here and there) 2011-09-05 14:01:50 +02:00
Nevan e8bb94d213 Tabs 2011-09-05 02:05:20 +02:00
Nevan 87b5f99b81 Twins Valk - Cleanup / Remove Hardcoded Bullet Spawn (Need DB Support - Stalkers Spawns)
Acidmaw - Use Correct Submerge Spell

Trial Of Crusader - Correct Coordinate Spawn
Trial Of Crusader - Correct Open/Close Main Door Timer
Trial Of Crusader - Open/Close On Boss EnterEvadeMode
2011-09-05 01:59:17 +02:00
Nay dca0e737de Core/Quests: Fix quests with RepObjective2 set. Closes #2901.
Misc: Correct a file name, move a spell error to error log and a small typo in trinity_string
2011-09-04 23:44:01 +01:00
Nay fd5ab97774 Core/Spells: Fix Distract. Closes #155 2011-09-04 01:58:44 +01:00
Nay 5a63d12457 Core: Fix indentation in SpellAuraEffects 2011-09-03 23:29:30 +02:00
Vlad 5a526d6d7f Core/Spells: Fix Shadowflame and others from spell_linked_spell with + + 1 db setting. 2011-09-03 20:38:23 +02:00
QAston ddacd0de94 Core/Spells: Fix pick lock - thanks to cyberbrest for pointing the reason of this issue. 2011-09-03 20:16:15 +02:00
hacknowledge 9d85446e30 Core/Spells: Fixed misdirection ability of hunters to end 4 seconds after first damage proc - fixes #114 2011-09-03 18:26:39 +02:00
QAston f31e676199 Fix build after recent pull merges. 2011-09-03 18:07:27 +02:00
sarjuuk b40bf69319 [Core/Threat] SpellThreat-Calculation revamped
short:
  - Threat is now distributed blizzlike (almost)

long:
  - Percent- and AP-Modifieres got add
  - Threat is now propperly distributed through multiple enemies
  - Most spells will cause initial threat in an amount equal to their SpellLevel
  - Energize-Effects will now be treated like healing (threat-wise)
  - Tanks got their missing +43% passive threat tacked on
  - Paladins are still missing 'Salvation' and will not only cause half threat with healing (essentially 25% of the amount healed)
2011-09-03 17:42:44 +02:00
QAston dc01541111 Merge pull request #2852 from Chaplain/cleanup2
Core/Misc: Cleanup - remove unused variables, add some const modifiers to functions, fix process of args in vmap3_extractor
2011-09-03 08:34:02 -07:00
QAston d23b03271d Merge pull request #2777 from KoffeinKaio/fishing
Core/Spells: Fixed fishing bobber landing angle.
2011-09-03 07:52:47 -07:00
QAston 414f048bd5 Merge pull request #2735 from hacknowledge/fix_2734
Core/Spells: Fixes ammo consumption for Hunter's Volley
2011-09-03 07:29:31 -07:00
Chaplain bea649d045 Core: cleanup.
*remove some garbage
*little bit moore const func
*fix process of args in vmap3_extractor
2011-09-01 22:38:32 +03:00
Shocker b83e858455 Core/Spells: Some aura defines 2011-08-31 12:37:19 +03:00
Shocker 4eb3a9ca48 Core/Spells: Rename SPELL_AURA_POWER_BURN_MANA to SPELL_AURA_POWER_BURN 2011-08-31 12:11:38 +03:00
Kapoeira 5d0a2b6094 Core/Spells: Fix Aspect of the Beast
Closes #462
Closes #2814
2011-08-30 20:24:36 +07:00
Spp- aa85553bfd Core: Crash fix (TemporarySummon), remove some warnings and some other minor changes
- "const uint64" and "uint64 const" --> uint64
 - Add some info in LFGDungeonEntry
 - Move some definitions from ".h" files and move to ".cpp"
2011-08-30 13:46:36 +02:00
QAston d863562507 Core/Spells: Make core be a little less strict about some spell attributes SPELL_ATTR0_CASTABLE_WHILE_DEAD and SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS checks. 2011-08-30 00:13:53 +02:00
QAston 2f79241237 Core/Spells: check unattackable flag only for negative spells. 2011-08-29 23:26:47 +02:00
Naga eba169e5f1 Fixed fishing bobber landing angle. 2011-08-27 14:34:56 +00:00
QAston 8754166071 Core/Spells: Send expected type of spell implicit target to client. 2011-08-27 12:59:57 +02:00
Nay 83912c43ad Core/Spells: Revert a (little) part of 85164d2876
DB: Fix startup errors Closes #2568
2011-08-26 18:04:35 +01:00