Commit Graph
3378 Commits
Author SHA1 Message Date
Manuel 3ab85db411 Core/Player: Pets are unsummoned after spec switch. Fixes #180 2011-01-14 13:38:56 -03:00
Machiavelli d399daab59 Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times.
All relevant upper level code has been updated accordingly to the best of my ability.
2011-01-13 23:06:59 +01:00
Machiavelli 57ee357c02 Core/Maps: Fix a possible crash in ObjectGridStoper:Visit
Dump found here: http://pastebin.com/2GZ3t5v4
2011-01-13 21:33:56 +01:00
Shauren 8d59953f93 Scripts/Icecrown Citadel
* Call EnterEvadeMode before teleporting players to entrance - prevents players being stuck in combat
* Fixed Gaseous Blight stacking damage
* Properly initialize phase for Professor Putricide when entering combat
* Fixed Blood Nova and Boiling Blood abilities of Deathbringer Saurfang
2011-01-12 22:50:51 +01:00
Machiavelli 52499b03ea Core/Guilds: Don't allow more than 25 and 100 log events to be sent to the client for bank eventlog and regular eventlog respectively. Higher values will result in client crashes. 2011-01-12 19:38:47 +01:00
Anubisss 806794d4ce Fix a crash in Spell::CheckCast().
This crash happens when effect is SPELL_EFFECT_TALENT_SPEC_SELECT and the caster is not a player.
You should always check object's type (or sure that object is 101% a player) before you use ToPlayer() casting function.

Signed-off-by: Anubisss <[email protected]>
2011-01-12 02:06:06 +01:00
Spp bd2728eb74 Core: Fix some warnings 2011-01-11 11:18:00 +01:00
Shocker f03040b5b3 Core/Spells: Glyph of Polymorph should remove leech auras too, fixes #171 2011-01-11 00:57:20 +02:00
Taser 1a5554ccb5 Core/Battlegrounds: Fix Fel Reaver Ruins capturepoint in Eye of the Storm
Signed-off-by: Machiavelli <[email protected]>
2011-01-10 22:31:57 +01:00
Shauren 870add0a3d Core/Spells: Fixed Spirit Walk ability of shaman's Feral Spirit summons
Closes #115

Signed-off-by: Shauren <[email protected]>
2011-01-10 22:01:19 +01:00
Machiavelli fa8e5047a6 Core/Guilds: Fix a possible client crash in MSG_GUILD_BANK_LOG_QUERY 2011-01-10 20:57:58 +01:00
Manuel 014714fb17 Core: Killing magic numbers. 2011-01-09 20:44:33 -03:00
Machiavelli 01d4080b4d Core/Units: Send proper orientation in SMSG_MONSTER_MOVE_TRANSPORT
Also get rid of the 100 constant in moveticks segment and use getMSTime() for consistency sake
2011-01-09 16:22:04 +01:00
Shauren 1aa294d3e9 Core/Players: Fixed typo in updating soulbound trade times (check every second, not every 1000 seconds) 2011-01-09 15:14:44 +01:00
Derex 45459bed23 Core/Netcode: Fix file descriptor leak under linux platforms with ACE dev poll reactor.
close #15

Signed-off-by: Machiavelli <[email protected]>
2011-01-09 13:53:25 +01:00
Manuel 5cf76896eb Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM-
Anyway the map is not yet playable, there are issues not related with the script.

I also want to thanks to QAston, linencloth, Shauren and Machiavelli to be so patient with my questions.
2011-01-09 00:00:08 -03:00
Machiavelli 58f795d171 Core/Vehicles: Logic fix for AddPassenger seat validity check, thanks to Tassader 2011-01-08 21:13:18 +01:00
McBitter 63333dc6ff Core/Spells: Fixed targeting for spell 49305 (missing unit target)
Signed-off-by: Shauren <[email protected]>
2011-01-08 17:40:10 +01:00
Shauren 39247d912b Core/Quests: Fixed quest chain issues introduced by daily quest fix
Closes #127

Signed-off-by: Shauren <[email protected]>
2011-01-08 13:57:59 +01:00
Shauren 051cceb7ac Core/Quests: Fix daily quests not showing up in list of available quests after having completed them once before. (Bug usually used to surface when in ExclusiveGroup)
Signed-off-by: Machiavelli <[email protected]>
2011-01-08 00:27:50 +01:00
Machiavelli dc3d6a2f23 Remove redundant code from 1487ebedaa 2011-01-07 19:13:19 +01:00
Christyan bc048ad216 Fix a typo in LFG.
Use the proper DungeonID for SMSG_LFG_PROPOSAL_UPDATE if player selected multiple dungeons.

Signed-off-by: Anubisss <[email protected]>
2011-01-07 01:30:39 +01:00
Machiavelli efe0ed3194 Core/Entities: Fix a silly typo in Object::AddExtraMovementFlag 2011-01-06 22:54:33 +01:00
Machiavelli c65e3822a2 Fix build from 06314c9387
closes #99
2011-01-06 22:45:07 +01:00
Sarjuuk 06314c9387 Core/Spells: Implemented Pygmy oil use effect
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 21:40:32 +01:00
Sarjuuk 8859aa689c Core/Spells: Implemented Improved Faerie Fire crit chance increase effect
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 21:37:16 +01:00
sarjuuk dfc848b88e Core/Spells: Periodic Dummy for spell 54798. Fixes quest 12851
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 20:25:51 +01:00
Ottowayne 7aa85728fc Core/Spells: Dummy for spell 51961; support for Quest 12532 & 12702
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 20:22:39 +01:00
Ottowayne 1487ebedaa Core/Spells: Dummy for spell 47703 (Unholy Union) for quest 12126
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 20:14:13 +01:00
sarjuuk 0cf89f635f Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS
Signed-off-by: Machiavelli <[email protected]>

Also minor codestyle fixes from previous commits
2011-01-06 19:57:36 +01:00
sarjuuk 20b49bccb0 Core/Spells: Set energy in cat form to zero on shapeshift before calculating energy gain from furor talent.
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 19:43:36 +01:00
Ottowayne b0c559e704 Core/Spells: Fix Spell 54577 - Support for Quest 12828
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 19:33:22 +01:00
Machiavelli 26c91be2d3 Core/Quests: Better way to fix the problem affected in previous commit
closes #36
2011-01-06 17:33:40 +01:00
Machiavelli c617f1f85c Core/Quests: Fix certain issues with repeatable quests.
closes #36

Signed-off-by: Machiavelli <[email protected]>
2011-01-06 16:49:04 +01:00
click 1251cf3f10 Fix typo (Note to self: USE THE RIGHT BRANCH WHEN DOING TESTCOMPILES!) 2011-01-05 18:18:37 +01:00
click 8bfc49cfa5 Core/Entities: Send SMSG_DISMOUNT notification to client when dismounting (mount/vehicle).
Thanks to Vladimir.
2011-01-05 17:55:57 +01:00
Machiavelli eac259f75f Core/Units: Call Unit::InterruptNonMeleeSpells before RemoveFromWorld to make GetCaster() return a valid pointer on AuraEffect unapply methods.
Fixes a crash in VisitorHelper related to Mind Vision.

closes #43
2011-01-04 23:43:20 +01:00
Shauren 3208b7ae1f Core/Auras: Prevent phase aura handler from incorrectly being stopped on aura removal
Closes #32
2011-01-04 22:41:44 +01:00
Machiavelli 09a0860717 Core/Pets: Fix crash added in a3feae6b6f 2011-01-04 19:30:51 +01:00
lukaasm 4fba0830d0 Core/Groups: Fix players being displayed as offline in group view after being teleported to a
different map

closes #48
Signed-off-by: Machiavelli <[email protected]>
2011-01-04 18:12:10 +01:00
Per Wilhelmsen a3feae6b6f Core/Handlers: Add guid-output for pet-guid and playerguid in HandlePetSetAction error-message. 2011-01-04 06:09:43 +01:00
leak 64ea69a66d Core/AuctionHouse: Restore Rate.Auction.Deposit and Rate.Auction.Cut functionality (Note: The client won't display any changes)
closes #6
2011-01-03 19:12:02 +01:00
Machiavelli 9f4881310f Core/Vehicles: Fix a crash in EjectPassenger
Closes #20
2011-01-03 17:02:26 +01:00
Anubisss 80da87f015 Add one more check to EffectDispel.
Passive auras are not dispelable.
This fixes a bug like spell Omen of Clarity (16864) can be dispelled by Purge (370) if you have a non passive aura like Mark of the Wild (1126).

Signed-off-by: Anubisss <[email protected]>
2011-01-02 22:43:36 +01:00
Shauren 9c0cd63e93 Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon 2011-01-02 21:33:37 +01:00
Shauren a3eff12b33 Core/Auras: Fixed transform aura stacking logic 2011-01-02 17:22:45 +01:00
Shauren eec299e605 Core/Spells: Cleaned up Shaman 4P Enhancement and Paladin 2P Retribution set bonus code
SQL: Added missing sql for that revision, thx cyberbrest

Closes #12
2011-01-02 16:27:38 +01:00
leak a7dadcb51c Prevent infinite absorption (and spell damage from Incanter's Absorption) when Chaos Bolt hits Mana shield. Patch by johnholiver.
Fixes #7
2011-01-02 13:42:14 +01:00
John Holiver 2b42dcadf7 Fix T10 Bonus for:
- Paladin 2P Retribution
- Shaman 4P Enhancement
2011-01-02 12:40:07 +01:00
Shauren 039d87bbc9 Scripts: Implemented virtual function DoCastSpellOnPlayers (self-explanatory) and CheckRequiredBosses checking states of other bosses before allowing combat with selected one
Scripts/Icecrown Citadel: Added checks to prevent skipping bosses
2011-01-01 23:37:35 +01:00