Commit Graph
26060 Commits
Author SHA1 Message Date
Killyana 48c8b650bb Spell/Script: Summon Scourged Captive
Closes #16357

(cherry picked from commit 0959f3071af5f4c2b20c926beb8c78c3454ffb4b)
2021-11-24 20:35:18 +01:00
Gustavo 80421d7cac Core/Players: Fix logic in CanSeeSpellClickOn (#23090)
Block SpellClick for the npc if there is no entry

(cherry picked from commit 0eacccc2cd614aaef790ad0ce9df3d57212e9b58)
2021-11-24 20:35:18 +01:00
Shauren 2be8a1f189 Core/Misc: PORT CURSED REFACTORS FROM e69570dd7662848ae38628c4af71cce002dd1c3d
WHO ON EARTH THOUGHT IT WAS A GOOD IDEA TO ADD REFACTORS TO A CHERRY-PICK COMMIT???
2021-11-24 20:35:18 +01:00
Keader 02db59806a Scripts/Trial of the Crusader: Fixed Slime Pool visual effect
Closes #21660

(cherry picked from commit e1aafddc2e90c01d0e2511518d7c23ac6baca935)
2021-11-24 20:35:17 +01:00
jackpoz 7a2ef47495 Core/Spells: Adjust range checks to GameObject targets
(cherry picked from commit 72052aa9a55683011969510f4aea6d1efd9c67c9)
2021-11-24 20:35:17 +01:00
jackpoz 71b58c2e62 Core/Spells: Adjust range checks to GameObject targets
(cherry picked from commit 270a144083d85d18cba8aff861dd6effbd04c476)
2021-11-24 20:35:17 +01:00
jackpoz 91bbaae81e Core/LFG: Teleport players to other players instead of dungeon entrance when continuing a LFG dungeon
This feature already existed in current code but was broken by d0334bf948

(cherry picked from commit d2841d6b664ac2c8e818bea1a469fdd3f1b31f6b)
2021-11-24 20:35:17 +01:00
Sorikoff a57ca5cea2 Core/Movement: Allow using run when moving randomly (#23081)
* Allow run when moving randomly

(cherry picked from commit 34cfa69efd1857540f1f44b118086bb02334c100)
2021-11-24 20:35:15 +01:00
jackpoz ace33a464f Core/Misc: Code cleanup
(cherry picked from commit 6c5d9971619ad1f3982defd67342571561dddb62)
2021-11-24 20:34:56 +01:00
jackpoz c312b926b4 Core/MMaps: MMaps logs cleanup
Move MMaps related logs from "maps" category to "maps.mmaps".
Remove newlines in logs, the log system already takes care of newlines.

(cherry picked from commit 696039cfed53334ed32583ec293db787e64ef5db)
2021-11-24 20:34:56 +01:00
Keader 955ac45cf5 Spell/Script: Freezing Circle
Closes #11312
See the original issue before cherry pick

(cherry picked from commit 990ad000f8e869e55353e6531d9e38f23104bcd6)
2021-11-24 20:34:56 +01:00
jackpoz bd0e9e7aa8 Core/MMaps: Fix infinite loop in Detour
Fix another infinite loop in Detour caused by degenerated triangles.
Check the result of some previously ignored Detour calls.
Update recastnavigation to 3a619d773deb7e3a15ee215217c825995fe71312 and apply some more custom changes

(cherry picked from commit c602220e02bed1ad76c9e60064eeec5fd97bfe80)
2021-11-24 20:34:56 +01:00
Killyana b0f10b505e Core/GameObject: Set loot state to Not ready when a gob is deactivated (#23072)
(cherry picked from commit 8dec9b97e211d9b9d5153a3f0d19097bae6fdeff)
2021-11-24 20:34:56 +01:00
Sorikoff 956158d299 Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing

(cherry picked from commit dbadb6369cf0b6d394fffaa1dedc612dfb5cbe2a)
2021-11-24 20:34:54 +01:00
sirikfoll 402e63427e Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues

(cherry picked from commit a8033420299d75bbcfd6efec610ec7f34f01bf75)
2021-11-24 00:02:13 +01:00
Sorikoff b3f75852c2 Allow walk when chasing (#23069)
(cherry picked from commit c2f2db08aa4f729fbd5b21528a215f6df0c131b6)
2021-11-24 00:02:13 +01:00
jackpoz 97401a2997 Core/Commands: Don't re-add active quests with ".quest add" command
(cherry picked from commit f17120cc784ee1f52a24424a78a64d71ad73b713)
2021-11-24 00:02:13 +01:00
jackpoz b8396f682c Core/MapScripts: Add support to GameObjects to SCRIPT_COMMAND_DESPAWN_SELF
(cherry picked from commit da19ad117e3c4c15793ba8f84738efaecb4d1428)
2021-11-24 00:02:08 +01:00
Aokromes 49e1ff34b7 Core/mmaps: add category to 2 logs
(cherry picked from commit a2f910fe5cc150b7459cc396ed8de66659a1128a)
2021-11-23 23:44:00 +01:00
jackpoz 2318013278 Core/MMaps: Add rcMedianFilterWalkableArea() to mmaps generation process
Add rcMedianFilterWalkableArea() to mmaps generation process to simplify some ground/water areas

(cherry picked from commit 7ddbc18aafe61434971013ed6126f5666011ab43)
2021-11-23 23:43:55 +01:00
jackpoz abb36a1e5b Core/Spells: Add range checks to GameObject targets
Close #23062
Patch by robinsch

(cherry picked from commit 76cc94f325ab68f66a4fa7b5d30316508e27c0ce)
2021-11-23 23:34:27 +01:00
Gustavo 10c915dd34 Core/Units: Only update height in SetHover if unit is bellow HoverHeight (#23061)
(cherry picked from commit 2dfea54533830b326ce9ac29d59de01d3fee503b)
2021-11-23 23:18:58 +01:00
Ovah 2dda5fb477 Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
https://github.com/Ovahlord/TrinityCore/commit/f6e9ff5ca4ed1a174052b350db0802e1fca9a1aa
https://github.com/Ovahlord/TrinityCore/commit/ed8c1830f58e0b9db629bbae9ee80f8ad76331e5

(cherry picked from commit c10c8c6bba27625e49016de8c1a1cc9fa7944fa5)
2021-11-23 23:17:08 +01:00
Shauren 7a413ae543 Core/Spells: Fixed spells using MovePositionToFirstCollision for selecting target position getting Z coord offset by caster or target collision height (depending on spell target type)
(cherry picked from commit d63d15c505708d175c52d87afc76cbe4ac59497b)
2021-11-23 23:16:49 +01:00
Keader dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc40977b7b019f79a198daebede90c59f5c1)
2021-11-23 23:16:43 +01:00
jackpoz ef04a26bf4 Core/Pet: Add assert
Add additional assert to check if it's possible for a Pet not to have an active AI when the Player owner kills an enemy.
Ref #23036

(cherry picked from commit 43dec9e4d0b6f7da3c2051624742e9fb8a9bcb31)
2021-11-23 23:10:45 +01:00
Heaven31415 0ea3fe545c Refactor SendSysMessage, SendGlobalSysMessage, SendGlobalGMSysMessage (#23029)
(cherry picked from commit 9db50f05cb7d225f3bd7b2a209509a072f915fd3)
2021-11-23 23:07:23 +01:00
Sorikoff ee0662ca3d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023)
(cherry picked from commit f0f4d0280daf81a841c30332f608f7acdfb1f374)
2021-11-23 23:04:34 +01:00
Shauren c14cf5a892 Core/Misc: Added lambda support to EventProcessor
Closes #22909

(cherry picked from commit 813f693768ee94864b0d24423b9265bde2c9903d)
2021-11-23 23:01:47 +01:00
Giacomo Pozzoni ed5ba915f1 Core/Scripts: Change PlayerScript and CreatureScript inheritance (#23048)
Remove UnitScript from PlayerScript and CreatureScript classes as that's how the original system that was PR'd worked, see https://github.com/TrinityCore/TrinityCore/pull/7867 for reference.
Please note these are used as global hooks and should really just invoke stateless functions.
If you need to hook methods from PlayerScript/CreatureScript and UnitScript, just define 2 different scripts (this is how the original system worked and how it was designed to work)

(cherry picked from commit 5b7ead65bb116195f4336934bcff830e1b2af5bb)
2021-11-23 22:54:24 +01:00
TheWinchesters 47adf2e4c8 [3.3.5] Commands: lookup player shows which character is online (#23039)
* Show 'online' for every online player in lookup player commands

(cherry picked from commit a0056951f7e425341760ebf3a7770477ef7f4446)
2021-11-23 22:52:53 +01:00
Giacomo Pozzoni 31dca39c05 3.3.5 threat assert (#23034)
* Core/Creature: Change assert about Threat to log

(cherry picked from commit cb8ff7976b1419c6a1334bb49783480d543aff16)
2021-11-23 22:48:39 +01:00
Giacomo Pozzoni 24f9b41622 Shared/Utilities: Handle string format exceptions
Handle StringFormat() exceptions in case of malformed string format to avoid causing unhandled exception crashes

(cherry picked from commit c79811de4fbf2b22cd74f55853516c7fc307055f)
2021-11-23 22:48:28 +01:00
Aokromes 2682bf0fca Core/Misc: Add categories to 3 logs
(cherry picked from commit 2d22c027fe0df505ddc63d4faaad032cddd5e258)
2021-11-23 22:29:21 +01:00
Aokromes f5827770fc Core/Spells: Add categories to 2 logs
(cherry picked from commit 1cba3633606291823dc0184ac4bca8fced8fefcd)
2021-11-23 22:29:01 +01:00
Aokromes c5720e37c1 Core/Entities: Add categories to 2 logs
Closes #22922

(cherry picked from commit 578c796625859656b788565378250f783a348b09)
2021-11-23 22:28:38 +01:00
jackpoz 23489568db Core/MMaps: Fix infinite loop in Detour
Fix an infinite loop in Detour happening in Dalaran Sewers.
This is more of an emergency patch until we figure out why dtNodes have a circular reference (A -> B -> C -> A) happening quite often in this place

(cherry picked from commit c8ec2dd95d07e3eec00027cdb9605529a49d6475)
2021-11-23 22:28:28 +01:00
jackpoz 3ddbf02dc7 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 2fda1572d214d0b114e0291106363f49c2d3179e)
2021-11-23 22:20:39 +01:00
jackpoz 9807f32334 Core/Misc: Fix issues reported by dynamic analysis
Closes #23021

(cherry picked from commit 9942047c721110b4d2135028ec4c17060e0301bc)
2021-11-23 22:19:06 +01:00
jackpoz 927e62e88e Core/Group: Fix memory leak
Fix memory leak happening when disbanding a group with an ongoing roll.
Please note this is not blizz-like but at least we don't leak memory anymore.

(cherry picked from commit f04e90f638425c0e0ef2e40f0cd29ab7eec625d1)
2021-11-23 21:28:23 +01:00
Sorikoff fc9106054b Scripts/Scarlet Enclave: Grand Theft Palomino (#22967)
* Grand Theft Palomino

* Cosmetic issues

* Address CR

(cherry picked from commit d5f565f42992d5142b30c7fbd694f8a5b1245f4c)
2021-11-23 21:28:03 +01:00
Chaouki Dhib 4507a02ada Core/Movement: Implement move time skipped handler (#22994)
* Implement CMSG_MOVE_TIME_SKIPPED handler and move it to MovementHandler.cpp

* Add better error handling

* Update MovementHandler.cpp

(cherry picked from commit f9ed72e351ecdafe77da2036d9fd68e46da2f3ab)
2021-11-23 21:18:07 +01:00
jackpoz e475cac631 Core/Spells: Fix assert triggered
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca08a362bc3709daaaa5e5d5633d1bf1

(cherry picked from commit 46c7446bd4ef606b1091c1582df50e027fab28b6)
2021-11-23 20:47:31 +01:00
Sorikoff 31f4bb1436 DB/Quest: Sniff Out the Enemy
Closes #23006

(cherry picked from commit 806dd940cec8352cc3a619b9cab39c95d7b86e59)
2021-11-23 20:46:27 +01:00
Keader 084491669e Scripts/Magister Terrace: Fixed a enum mistake
(cherry picked from commit 33b0654f8eb7aedf2a5a7d6b88f222ce31d20331)
2021-11-23 00:40:07 +01:00
Keader cfd0e18b81 Core/Misc: Fixed shaman elementals and magister terrace first boss access
(cherry picked from commit 6545cd33b91468de7c1b4beb77cdeb4ecb77f501)
2021-11-23 00:39:59 +01:00
Keader 4a943fd3d2 Scripts/Utgarde Keep: Fix Ingvar Evading (again)
UNIT_FLAG_NON_ATTACKABLE makes ingvar become a invalid target and lose threatlist, so me->IsThreatened() will return false.
We dont need it at all, since UpdateAI will handle evade already.

(cherry picked from commit 71dde16ce9a9c7904a2902ae288b3f05851224ac)
2021-11-23 00:39:17 +01:00
Keader 5c48cac6f9 Scripts/Temple of Ahn Qiraj: Scripted doors of AQ40
Doors added in https://github.com/TrinityCore/TrinityCore/commit/1ba09572b5a49d5cd247cdca47109d3325ec12f3

(cherry picked from commit 06078e30c6f1d6e2ab1dcecbba15127b07b32bb7)
2021-11-23 00:39:17 +01:00
Ovah 3027458338 Scripts/Magister Terrace: Update InstanceScript and more fixes
Cherrypicked of https://github.com/Ovahlord/TrinityCore/commits/4.3.4

(cherry picked from commit 1b346485e40ddee958c116579d93bcff063021a5)
2021-11-23 00:39:13 +01:00
Ovah 3847d7b277 Scripts/Magister Terrace: Felblood Kaelthas rewrite
Cherrypick of https://github.com/Ovahlord/TrinityCore/commit/ae440400aaf90de11cf92010839ab98a8403c003

(cherry picked from commit 00958c9178781ac11a9dcabd034ed2e82120fad6)
2021-11-23 00:21:42 +01:00