Commit Graph
27578 Commits
Author SHA1 Message Date
Kargatum 373ed8f46b Core: whitespace cleanup, reduce double blank line to single (#25795)
* Core/Misc: fix double empty line

* worldserver.conf

(cherry picked from commit a32b6b8ac4c81128a56b282f20837fb085bdd9e7)
2022-03-05 20:07:57 +01:00
Aurelio Arcabascio 05a9b2d2cb Core/Player: auto-attacked player stands up from sit or sleep state (#25684)
* Fixed Auto Attack bug on sitting player

* Victim now stands during sleep and stand emotes

(cherry picked from commit 4ea64b515aa952662dce11fd1012c566ae0d2449)
2022-03-05 19:41:18 +01:00
Treeston 5b9fec5f0b Core/Maps: Move some more Map internals to actually be... internals.
(cherry picked from commit 94c03b2107ad6603aaf185d58d63480e79c97e76)
2022-03-05 17:12:51 +01:00
Treeston b5f3a6fd80 Core/Maps: All RespawnInfo* handed to outside code are now RespawnInfo const*, to signify that outside code has zero business changing these.
(cherry picked from commit 803dc789e42ea2298a8bd1822849b6f2df82efe6)
2022-03-05 17:12:23 +01:00
Giacomo Pozzoni da0d9ee283 Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance (and other SMART_ACTION_CAST fixes) (#25778)
* Core/SAI: Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance

Fix SMART_EVENT_FLAG_NOT_REPEATABLE flag being ignored when specifying a chance, always making the action trigger.

* Fix SMART_ACTION_CAST with SMART_EVENT_FLAG_NOT_REPEATABLE not casting the spell at all if rolled chance was successful but creature couldn't cast the spell

* Prevent linked actions if SMART_ACTION_CAST couldn't be completed and will be retried later

(cherry picked from commit 96b289cadbf304e427ddbd281d1a6f592af612a7)
2022-03-05 17:11:58 +01:00
Treeston a8d00ddd69 Core/Maps: move pooling hand-off outside of Map::CheckRespawn (PR#25785)
fixes #25777

(cherry picked from commit f8afcec9f3efc58ce8a38a6c63e2ebfc24d2e01d)
2022-03-05 17:07:46 +01:00
jackpoz abbac041bf Scripts/ICC: Fix teleporter not removing players from Gunship
A more generic solution might be better, maybe depending on spell flags

Ref #25652

(cherry picked from commit 0ad1854d1c6a3b6ff93e71272c919f1f5f11d5ed)
2022-03-05 17:03:54 +01:00
Giacomo Pozzoni 30ebecc0de Core/Maps: Attempt to fix picking the wrong min height (#25771)
Close #25652

(cherry picked from commit aabd2b49e2710e00c39c4b4f22fef08aa029d4db)
2022-03-05 17:03:14 +01:00
jackpoz 90a05037cf Core/Maps: Partially revert 0c69316714d0558e32462f5401197fe1e803ae75
Revert define to constexpr as this also broke some calculations

(cherry picked from commit ed1c0b6ec9232cc638fa242ea839c4645bb4be07)
2022-03-05 17:03:02 +01:00
jackpoz bea8894bce Core/Maps: Partially revert 0c69316714d0558e32462f5401197fe1e803ae75
The development will continue in a PR

(cherry picked from commit 1e3d85e2839c5ee3170223f4d985eecd527c5533)
2022-03-05 17:02:38 +01:00
jackpoz 26962127a5 COre/Misc: Remove whitespace
(cherry picked from commit 01b1f20d3ea1f1dca3d614396634c85646b77ff8)
2022-03-05 17:02:30 +01:00
jackpoz c14f4dc835 Core/Maps: Use the same logic to calculate grid coords to avoid mismatches
Use the same logic of (CENTER_GRID_ID - x / SIZE_OF_GRIDS) in GridMap::getMinHeight() as Map::GetGrid() to avoid coord grid mismatches caused by floating point precision, i.e. getting the wrong grid.
Replace defines with constexpr in grids to make debugging easier.

Closes #25652

(cherry picked from commit 0c69316714d0558e32462f5401197fe1e803ae75)
2022-03-05 17:02:19 +01:00
jackpoz 13bf0e71b9 Scripts/Commands: Include map min height in ".gps" command
(cherry picked from commit 9994459bd197d5555cfa16ab3d35d9c362a563fd)
2022-03-05 17:01:36 +01:00
offl c6df84da70 Core/Scripts: Add missing spells to Black Morass
(cherry picked from commit f62306f52d28f8c16047b27bd741d4356958da75)
2022-03-05 16:59:14 +01:00
offl c7f64a70a0 DB/Spell: Add effects to more spells from Violet Hold
Turned out almost all spells from BM were copied to create Violet Hold. Not only serverside spells and not only their effects but also attributes and icons. The scripts were also copied, possibly unchanged

(cherry picked from commit 8ca575ed52fb4ee8149302ecf33b4bb0c33e5eb5)
2022-03-05 16:58:55 +01:00
Ovah dde5a3e326 Core/SAI: implement new smart actions to change AI Animkits and to enable/disable hover movement (#25623)
SMART_ACTION_SET_HOVER (parameter1: enable/disable)

* added SMART_ACTION_SET_AI_ANIM_KIT as immediately deprecated

(cherry picked from commit b7ba856b63da4fa1b0f916de357ff85624b8b831)
2022-03-05 16:46:42 +01:00
Gildor 6b681ebc8a Core/Visibility: Split BG/Arena visibility settings (#25690)
(cherry picked from commit 8217519ea2d64917d725d8141fb3247bcadf716b)
2022-03-05 16:25:30 +01:00
offl 2e7277ada4 Core/Scripts: Add missing spells to Violet Hold
(cherry picked from commit bb94aec9759f05f7d4c91b7e2c5288c302897b3a)
2022-03-05 16:21:22 +01:00
Treeston 57f382d91c Game/ChatCommands: Make sure ChatHandler::extractPlayerTarget populates the strtok buffer for non-nullptr returns. Closes #25692, supersedes #25698.
(cherry picked from commit c8c572d9800ae20cb0a89fb666003213655704c8)
2022-03-05 01:02:18 +01:00
jackpoz 362a1c32c2 Core/Movement: Add a debug log when a player falls below the map
(cherry picked from commit 1c08395e8acf0ecebcc3fcaf24201b2ad44ed2dd)
2022-03-05 00:56:56 +01:00
offl 3a4ce889ea DB/Creature: Properly apply CREATURE_FLAG_EXTRA_NO_SKILLGAIN
Closes #25674

(cherry picked from commit cc98f68ac7fa06c134463903c5c887a7ad2f72a5)
2022-03-05 00:55:29 +01:00
offl 95d46bb7df DB/Instance/Arcatraz: More adjustments
(cherry picked from commit 6af54eb508b337dd61ba6039ddf60ff6438308a3)
2022-03-01 23:28:45 +01:00
jackpoz 20e96eead4 Core/Player: Adjust fall damage log
Move fall damage log to "entities.player.falldamage" category and include the usual debug info

(cherry picked from commit 5270ff58daf31ce10919d9da53e09f494956a5f2)
2022-03-01 22:49:22 +01:00
Treeston 2319a99d87 [3.3.5] Scripts/Commands: .learn adjustments (PR #25454)
(cherry picked from commit cc8287927b9c9f0bf20143972fd4d3c338bff688)
2022-03-01 22:48:06 +01:00
Ovah 203dfec2a1 Core/Maps: add new FLAG_ALLIANCE_ONLY and FLAG_HORDE_ONLY for instance spawn groups (PR #25656)
(cherry picked from commit 4abbeb2a60370157bc9a72e5c566c1112ff904e9)
2022-03-01 21:46:43 +01:00
offl 39e9983205 DB/Creature: Convert & update support for Tonk Mine to SAI
(cherry picked from commit ed8bf7f0e2e67ca1eb65ffa05518fe29df526642)
2022-03-01 00:00:39 +01:00
offl c883c0ee1f DB/Quest: Update support for 'Merciful Freedom' (11676)
(cherry picked from commit 05fa1a46b36f81c177a503f7f5de14eb34830208)
2022-02-28 23:59:55 +01:00
offl 0b0532e96a DB/Quest: Convert & update support for 'Prison Break' (11587) to SAI
(cherry picked from commit dc4cb8f1d3895316c6ecc7a47c392a6da7a9f948)
2022-02-28 23:59:23 +01:00
Jildor b3b635c6c8 DB/Instance/Ulduar: Add missing spells for heroic mode
Closes #25637

Closes #25638

Closes #25639

Closes #25640

(cherry picked from commit ef9576c7bbb42e0aa818a606284da25ea15999c4)
2022-02-28 23:57:58 +01:00
offl c267c015ed DB/Quest: Convert & update support for 'The Spider God' & 'Hive in the Tower' to SAI
(cherry picked from commit e5fd5cc031b13b802939590a755eef29f276f44f)
2022-02-28 23:50:42 +01:00
offl d5e49ff0d2 DB/Instance/The Arcatraz: Update auras, scripts & stats
(cherry picked from commit a2da08deb19b64725bb6d4c3c387bb58da0e1dcf)
2022-02-28 23:48:05 +01:00
Keader 281aef7c40 Scripts/Black Temple: Some little fixes
- Fixed Reliquary of Souls ignoring boundary
- Fixed Maiev texts timer
- Fixed Shadow Prison hitting every single npc on black temple

Many thanks to Ovahlord

(cherry picked from commit 83e0a70ddce81ac3d3552689d975b0f2c0262b49)
2022-02-28 23:46:41 +01:00
Keader 2e2f93b94f Scripts/ScarletMonastery: Decrease boss number
Headless Horseman do not use BossAI anymore (since it can be done multiple times)

(cherry picked from commit 3c201b75543106d6daa693dae0eca39f8efdfa22)
2022-02-28 23:38:49 +01:00
Keader 8d841679fc Scripts/ScarletMonastery: Headless Horseman Rewrite (#25614)
(cherry picked from commit a93abcf8031fc3b4dc6db16aa09d92a221bc6a77)
2022-02-28 23:38:36 +01:00
jackpoz 1ba5e17c95 Core/AI: Fix CorpseRemoved() and SMART_EVENT_CORPSE_REMOVED not being called for creatures without m_respawnCompatibilityMode
Fixes #24958

(cherry picked from commit 28a1132211aaf8d43e3459a7dc8ee093df1bcfa0)
2022-02-28 23:14:37 +01:00
Giacomo Pozzoni b7a3124156 CI/GitHub: Switch to GCC 8 (#25610)
* CI/GitHub: Switch to GCC 8

Build on GitHub Actions using GCC 8 as it's the oldest supported GCC

* Core/Misc: Attempt to fix GCC 8 build

(cherry picked from commit d7459cccedc7ca9ba85e209dfeef61969fc78d9a)
2022-02-28 23:13:59 +01:00
offl 4316d65ebe DB/Instance/AQ40: Update gossips
Closes #25577

(cherry picked from commit 7fd12cc7226f96957b45200a395a1ebad05985e8)
2022-02-28 23:11:34 +01:00
Shauren 357147834e Core/DBLayer: Fixed memory leaks with existing SQLQueryHolder uses and eliminated the possibilty of adding more in future (replaced manual memory management with smart pointers)
(cherry picked from commit 53482f729995889936ad8fba9fc5789d9cdba85a)
2022-02-28 22:41:36 +01:00
Keader 649716f827 Scripts/ICC: Some fixes in Valkyr Shadowguard (#25572)
- Added missing transformation spell
- Fixed Soul Siphon casted in random targets. It should always cast in top threat player.
- Fixed combat reach of transformation

(cherry picked from commit 5fee99bdbcabefca9b27308053f68d947c169b22)
2022-02-28 21:37:37 +01:00
Treeston 1bbf61ef02 AI/CreatureAI: Properly update Victim even while spell focusing
(cherry picked from commit 684910a230b2e8e780ad24bc0c4eece835bc249a)
2022-02-28 21:36:50 +01:00
Keader ab189bfc42 Scripts/ICC: Fixed Chocking Gas killing Abomination (#25565)
(cherry picked from commit 3c0766df545f4c2d2d045272f37087deccea458d)
2022-02-28 21:36:21 +01:00
Gildor 503ac5556d Script/Commands: .character changeaccount now disconnects player before transferring (PR #25560)
(cherry picked from commit b70314b0754327eeb44465c44af8368b4d020f92)
2022-02-28 21:34:39 +01:00
Keader f6409efcf6 Scripts/UtgardPinnacle: Implemented Beast's Mark (#25557)
(cherry picked from commit 182fcc919eadb1c58d76767545327a7fb3b2b3a4)
2022-02-28 17:00:20 +01:00
Keader ec3cb55d2f Scripts/IcecrownCitadel: Implemented Vampiric Might spell (#25556)
Closes #21294

(cherry picked from commit dadc0c98c098e0a9555124dc042687a80c89b79a)
2022-02-28 16:59:09 +01:00
Gildor 6cd16b0ca9 Core/Spells: Aura refresh improvements (#25511)
(cherry picked from commit c13ccaab5c70361d3a51005a1ce374291835b39c)
2022-02-28 16:04:48 +01:00
Gildor ad7ed08c07 Scripts/Ulduar: Implemented Realm First! Death's Demise (#25530)
* Scripts/Ulduar: Implemented Realm First! Death's Demise

* comment line

* Rename 9999_99_99_99_world.sql to 2020_10_08_01_world.sql

Co-authored-by: offl <[email protected]>
Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit ce2d4413049548ad9e5ed61d09eaa204cf0952fe)
2022-02-28 16:01:25 +01:00
Treeston 1feb53939d Core/ChatCommands: Fix a potential crash if a custom chat command does not have a specified help string
(cherry picked from commit 3ec98bf2410bb8fa73fe6b386a6e766bef575e97)
2022-02-28 15:54:08 +01:00
jackpoz eb17e94b2e Core/SAI: Fix SMART_ACTION_WP_RESUME actually pausing next waypoint if the current path was not paused
Fixes #25519

(cherry picked from commit 5be7c2ad4f7cd561951e1285227211e03886703f)
2022-02-28 14:42:53 +01:00
jackpoz b059f2f8ee Core/SAI: Allow to debug SmartAI methods
(cherry picked from commit 59bb822f78291c3b0d7b5811478637729569e07d)
2022-02-28 14:42:40 +01:00
offl f930508e83 DB/Instance/Auchenai Crypts: Complete overhaul part 1
(cherry picked from commit 60ded4ea4796b134b1dbdfb7071201c9ba3a9c71)
2022-02-28 14:42:00 +01:00