Commit Graph
101 Commits
Author SHA1 Message Date
thenecromancer 9880a4985b Fix Rated Arena scores display (Matchmaking Value is not implemented)
--HG--
branch : trunk
2010-01-25 02:38:18 +01:00
Anubisss d9cb070215 Implement QueryResult_AutoPtr type which is ACE's reference counted auto_ptr(ACE_Refcounted_Auto_Ptr) for QueryResult pointers.
Use this auto_ptr for every DB queries(except QueryNamedResult yet).

This patch guarantees NO memory leaks from QueryResult pointers.

Thanks to raczman for the idea and for the helping to make this patch.

--HG--
branch : trunk
2010-01-23 14:45:58 +01:00
n0n4m3 99f66a6bc9 Updated copyright for new year.
--HG--
branch : trunk
2010-01-16 20:19:18 +03:00
n0n4m3 4737d8111a Revert some commits. Now repo is stable. I recommend to disable Wintergrasp, because now its use leads to a crash.
--HG--
branch : trunk
2009-12-27 11:27:38 +01:00
Machiavelli cb2cb590e3 Fix a crash in BattleGroundMgr::BuildPvpLogDataPacket caused by objmgr not finding player object by guid when showing scoreboard. In this case get bg team ID for player via character database. Closes #938
--HG--
branch : trunk
2009-12-25 19:44:15 +01:00
Machiavelli f75c0f8081 Revert 6776. Do not revert my commits without asking me. Removing a functionality is never a fix for an issue, it should have stayed in place so that I can get accurate feedback on the cause of the problem.
--HG--
branch : trunk
2009-12-25 19:12:42 +01:00
n0n4m3 640a81c877 Temp revert 6724,6726 commits
--HG--
branch : trunk
2009-12-25 18:55:17 +01:00
n0n4m3 250a00cc1c Temporary revert 6743 commit. I fix this patch across 1-2 days.
--HG--
branch : trunk
2009-12-24 10:20:15 +01:00
Machiavelli f604193fd2 Hopefuly fix the queue icon for arena's. It should now properly show the faction/arena icon and correctly show skirmish/rated depending on the match type. Please leave feedback in the issue tracker as I'm unable to test this, make sure to add the output of the debug message I added.
--HG--
branch : trunk
2009-12-23 12:47:57 +01:00
n0n4m3 3fe0bc5254 Replaced time(NULL) on sGameTime.GetGameTime() this is used for better performance.
Original Timer.h divided into 2 parts. Shared project has no need to know about GameTime Singleton.
2 Identical structures with different types are now replaced with one generic templated structure and 2 typedefs.

--HG--
branch : trunk
2009-12-23 08:04:10 +01:00
Machiavelli d2770029ae Send arena team name as uint8(0) in case of a nonrated match in MSG_PVP_LOG_DATA.
--HG--
branch : trunk
2009-12-22 16:14:44 +01:00
Machiavelli e78bf5d666 Fix MSG_PVP_LOG_DATA (battleground statistics) that was broken since 3.1
--HG--
branch : trunk
2009-12-22 13:38:44 +01:00
maximius dc1207139a *Cleanup, proper indentation, and remove some wrong/irrelevant comments copied from custom patches..
--HG--
branch : trunk
2009-12-18 13:41:30 -08:00
n0n4m3 5697ea9c94 Update BattleGround System for 322a
--HG--
branch : trunk
2009-12-17 10:43:12 +01:00
Kudlaty 353a9f3740 Apply #413
Implementation of Ring of Valor (Orgrimmar Arena)
Patch by Spp and Opterman

--HG--
branch : trunk
2009-11-27 02:03:50 +01:00
maximius 654519d1a6 *Some cleanup (mostly whitespace changes)
--HG--
branch : trunk
2009-11-20 19:11:28 -08:00
maximius 3f338cc1c3 *Massive cleanup redux.
--HG--
branch : trunk
2009-10-17 16:20:24 -07:00
maximius e585187b24 *Backed out changeset 3be01fb200a5
--HG--
branch : trunk
2009-10-17 15:51:44 -07:00
maximius 26b5e033ff *Massive cleanup (\n\n -> \n, *\n -> \n, cleanup for(...) to for (...), and some other cleanups by hand)
*Fix a possible crash in Spell::DoAllEffectOnTarget

--HG--
branch : trunk
2009-10-17 15:35:07 -07:00
maximius 69f4e5e9b5 *Backed out changeset a09fe1125922
--HG--
branch : trunk
2009-10-13 19:59:34 -07:00
maximius b4c7a2514d *Blackfathom Deeps - Event: Aku'mai, by Tartalo
*Split Personality Achivement, by Destalker
*Halls of Lightning Fixes, by Destalker
    Volkhan fixes + Achievement
    Ionar Fix - without this he resets each time he is invisible, spamming sparks
    Arcing Burn - should be a debuff (and stackable, stackable part NYI :/)
*Naxxramas - Thaddius - the aura shall affect only the character without the proper aura, by Trazom
*Naxxramas - Kelthuzad - some timer adjustments (may need verification or tweaking) by Cass
*Merges by Stryker, thanks to all authors and testers.
[8458] Re-implement SPELL_AURA_MOD_TARGET_ARMOR_PCT in more porper way for weapon dependent cases. Author: VladimirMangos
[8459] Avoid mutiply apply weapon dependent armor penetration bonus for each weapon. Author: VladimirMangos
[8529] check rune cost only if spell has PowerType == POWER_RUNE. Patch provided by yavi. Author: Ambal
[8532] Fixed situation where some items like 42947 were not giving spell power bonus. By: Ambal
[8533] Not remove timed quest and correctly fail when time runs out. Add function to remove timed quest instead of direct access to set. Author: NoFantasy
[8536] Fixed spell 62776. By: Ambal
[8539] Check pet aura range at area aura update. By: Ambal
[8546] Implement battleground bonusweekends call to arms. Also fix typo in auctionmgr. Author: balrok
[8547] Implemented scriptcall: CorpseRemoved(uint32 & /*respawnDelay*/) it will be called when the corpse of the scripted creature get's removed, it's possible to adjust the next respawn inside the script. Author: balrok
[8561] Replace another auras code call by explicit code
[8566] avoid singleton-lock when accessing BattleGroundMGR::isBGWeekend() Proposed by vladimir. Comitter: balrok

--HG--
branch : trunk
2009-10-09 20:48:55 -07:00
maximius 5ab96a29f1 *Proper arena_pending_points update, thanks ogeraisi
--HG--
branch : trunk
2009-09-30 04:26:35 -07:00
maximius 3c43ef7157 *Better support for negatives.
--HG--
branch : trunk
2009-09-30 04:18:07 -07:00
maximius f0d5924891 *Cleanup, add two new functions, attempt to fix arena point flushing for offline players.
--HG--
branch : trunk
2009-09-30 03:29:08 -07:00
maximius 2bb0c31978 *[8474] Allow to delete BattleGround objects when any of invited players didn't click to enter battle. Rename m_TeamScores500disadvantage to m_TeamScores500Disadvantage, and optimize its update. Patch is tested. Author: Triply
*Added some missed changes that might of broken compile in the last 2~ commits.
*Some fixes to Warlock's Death Coil by Gyullo.
*Last MaNGOS merge until KingPin says otherwise..

--HG--
branch : trunk
2009-09-11 16:25:11 -07:00
megamage 19bfa37ec6 [8405] Fixed possible crash in BGQueueRemoveEvent::Execute() when two paralell BattleGroundQueue Updates are called, optimalized code.
Signed-off-by: Triply <[email protected]>

--HG--
branch : trunk
2009-08-24 19:34:56 -05:00
Kudlaty 02071a74c0 Fix typo
--HG--
branch : trunk
2009-08-21 22:32:48 +02:00
Kudlaty 395b1f5130 Fix typo in battleground announcer. Thx Gyullo
--HG--
branch : trunk
2009-08-21 22:19:06 +02:00
megamage 7f8ce1d809 [8315] Fixed memory leaks (mostly at server shutdown) and code cleanups. Author: VladimirMangos
* Fixed leak in BattleGround::m_PlayerScores at BattleGround::Reset,
      add and use BattleGroundScoreMap typedef
    * Delete AreaTeam objects stored in global map at shutdown
    * Delete Corpse objects stored in global map at shutdown
    * Store guild bank log entries as objectes instead pointers in log event lists

--HG--
branch : trunk
2009-08-06 17:45:37 -05:00
QAston 1d96091d2a *Improvements in map managing.
--HG--
branch : trunk
2009-08-01 00:20:32 +02:00
megamage 06123fa3af *Add config option Arena.QueueAnnouncer.PlayerOnly
--HG--
branch : trunk
2009-06-19 19:30:32 -05:00
megamage 48ea016135 *Fix bg queue announce.
--HG--
branch : trunk
2009-06-19 12:41:16 -05:00
megamage c17e9d62ab *Fix incorrect level in the bg queue announce
--HG--
branch : trunk
2009-06-19 11:29:34 -05:00
megamage 9d670fe6f5 *Switch to support client version 3.1.3
*I strongly recommend you not to use this until you get the 313 db. Now all destructible buildings cause client crash.

Source: Mangos
Thanks to TOM_RUS for most work to make this switch possible ;)

--HG--
branch : trunk
2009-06-11 00:45:59 -05:00
panaut0lordv f6447e8f34 *Including style fixing - part 1
--HG--
branch : trunk
2009-06-04 21:41:07 +02:00
megamage f92e8315cf [7918] Improve portability in work with uint64 string format specifiers and in code literals. Author: VladimirMangos
* Replace platform seelction MaNGOS code for select format descriptor for uint64 by using ACE define.
      I64FMTD renamed to UI64FMTD for more clear name.
    * Add new define UI64LIT (base at ACE seelction) for build portables uint64 literals.
      Please always use UI64LIT(0x00001) instead less portable 0x00001LL

--HG--
branch : trunk
2009-05-31 16:15:12 -05:00
megamage 295b634ca6 [7731] Some code cleanups, warrning fixes. Author: VladimirMangos
--HG--
branch : trunk
2009-04-29 00:31:03 -05:00
megamage 09af28301e [7716] Fixed some typos and possible crashes. Author: AlexDereka
--HG--
branch : trunk
2009-04-27 18:42:35 -05:00
megamage 1294bbac41 [7632] more "if"-condition related codestyle in battlegroundfiles Author: balrok,Triply
this time with this regex:
    sed -i 's/if *( *\(.*\) *)$/if (\1)/' BattleGround*

--HG--
branch : trunk
2009-04-08 16:33:46 -05:00
megamage 3a21b3d758 [7631] Removed useless method BattleGroundQueue::BGEndedRemoveInvites Author: Triply
Moved method BattleGroundMrg::InvitePlayer to BattleGroundQueue::InviteGroupToBG
    Added some comments to RemindInvite and RemoveInvite events.
    Optimalise code.

--HG--
branch : trunk
2009-04-08 16:29:28 -05:00
megamage cb8b3fe5db [7607] Improvements in support some generic achievement classes Author: VladimirMangos
* Implement support achievements with refAchievement field != 0, that have criterias stored in achievement refAchievement.
    * Implement support achievement complete req. with specific count of completed critirias.
    * Avoid full achievement list scan at search achievement associated with criteria.

--HG--
branch : trunk
2009-04-03 16:36:20 -06:00
megamage 7d9a71a6cf [7523] Fixed: players will now drop flag in battleground if they cast immunity buff on themselves. Author: `win
TODO: players who carry flag in bg are imune to immunity buffs casted by friendly players. (todo added to code).
    Bug: if paladin casts Hand of protection on flag carrier - flag will be dropped, but he should get "target is immune" message.
    Fixed: Do not call Battleground::Update for battleground template objects.
    Fixed: Do not allow immune player to click on object in battleground (not sure if this is correct in all cases).

--HG--
branch : trunk
2009-03-24 09:36:50 -06:00
XTZGZoReX 9fe43fa9c0 * Implementing database logging:
** LogTime and LogColors config options removed due to incompatibility.
** Old file logging still available.
** Totally redone the Log class.
** Config options added: EnableLogDB, DBLogLevel, LogDB.Char, LogDB.RA, LogDB.GM -- remember to update config file.
** SQL updates attached.

--HG--
branch : trunk
2009-03-19 21:13:52 +01:00
megamage c823272e34 [7449] Fixed BG queue invitation status showed on client. Fixed BG starting timer and BG ending timer. Author: Triply
TODO: make bg queue update player's status each minute.

--HG--
branch : trunk
2009-03-13 18:06:36 -06:00
megamage a0fede4fc2 [7437] Fixed client visible instance ids for battlegrounds. Author: balrok
--HG--
branch : trunk
2009-03-10 15:30:44 -06:00
megamage 1c151b7244 [7436] Fixed Average Wait time for all BG/arena queue types. By Balrok and Triply.
--HG--
branch : trunk
2009-03-10 15:29:50 -06:00
megamage f014ccd3bd [7416] Fixed minimap icon for battlegrounds and arenas. Author: balrok
--HG--
branch : trunk
2009-03-09 17:08:07 -06:00
megamage c708eba713 [7415] Fixed removing player from battlegrounds Author: Triply
Probably fixed bug with not ending battlegrounds - reported in previous commit message
    Fixed player will loose arena rating if
    1. he doesn't click on enter rated arena window - and timer will expire
    2. he logs out during time he is invited to rated arena match
    3. if he logs out during fight in rated arena match
    Patch is not tested, i will test it as soon as possible.

--HG--
branch : trunk
2009-03-09 17:07:40 -06:00
megamage 1f296b7d40 [7414] Fixed premature finish timer messages for battleground (va_start was broken). Author: Triply
Fixed typo with BattleGroundPlayerMap.
    Optimized implementation for removing offline players from battleground.
    Fixed typo in BattleGroundMgr::DeleteAllBattleGrounds.
    Patch is tested and should work.

    TODO there is a bug if you disable premature finish timer, that can cause battlegrounds to be never ending!
    TODO rewrite BattleGround::RemovePlayer function - and fix bugs there!
    I might not have today enough time to fix those bugs.

--HG--
branch : trunk
2009-03-09 17:07:12 -06:00
megamage 520ce96257 [7399] Rewrited BattleGround starting code - moved it to battleground class. Author: Triply
Fixed message color for premature finish warnings.
    Fixed .debug bg command won't allow 1v0 arenas now, only battlegrounds 1v0.
    Added battleground announcer message removed in [7384].

[7401] Fixed bgqueue invitation to already started battlegrounds - not tested. Author: Triply

--HG--
branch : trunk
2009-03-07 12:05:30 -06:00