Commit Graph
10354 Commits
Author SHA1 Message Date
Shauren dfeb41f7d9 Core/Items: Readded enchantment loading fix
--HG--
branch : trunk
2010-09-25 15:45:52 +02:00
Shauren 57df06c7f5 Core/Spells: Fixed power burn effects showing mana restored to caster
Closes issue #4078.

--HG--
branch : trunk
2010-09-25 15:03:48 +02:00
Machiavelli 311ae331ad Core/InstanceSaveMgr: Statically define ResetTimeDelay as class member instead of redefining it in different functions
--HG--
branch : trunk
2010-09-25 14:47:24 +02:00
Shauren 24e24020d1 Core/Players: This should fix crashes related to trading soulbound items
Updates issue #4162.
Updates issue #4165.

--HG--
branch : trunk
extra : rebase_source : eb30f245cb3a24ade6823d2fbb025cc9998870df
2010-09-25 14:12:50 +02:00
Machiavelli a24b84e6f7 Core/Commands: Fix a crash in .account onlinelist
Fixes issue #4176

--HG--
branch : trunk
2010-09-25 13:58:29 +02:00
Machiavelli 477b30a1ad Core/DBLayer: Fix a memory leak in Field class, properly clear buffer before repopulating it.
Fixes many issues (from wrong subnames on NPCs to absent GO/Creature spawns)
Thanks to Rat for helping find the issue

--HG--
branch : trunk
2010-09-25 13:12:12 +02:00
click 0fa7d24637 BuildSystem: Use correct variable-name for the SQL-installation
Closes issue 4163

--HG--
branch : trunk
2010-09-25 08:06:58 +02:00
Machiavelli 62946f9ef6 Core/DBLayer:
- Rewrite KeepAlive method for DatabaseWorkerPool. Use mysql_ping instead of explicit select queries, and also schedule KeepAlives for asynchronous threads.
NOTE: While the function is implemented and previous keepalive calls were transformed, it´s possible the keepalive call will need to be placed in several other locations in the code. Please leave feedback on whether or not this fixes your timeout issues.

Update issue #4062

--HG--
branch : trunk
2010-09-25 01:05:24 +02:00
Machiavelli 154d11acc0 Core/DBLayer:
- Fix another pesky linux specific compile error. (Thanks to Derex/Aokromes)
- Fix a typo in an assertion. (Thanks to Derex/Aokromes)
- Add proper zero termination in SetStructuredValue to get rid of memory issues that arose in the last few commits.
- Fix a crash caused by vsprintf´ing std::string in SystemMgr::LoadVersion()

--HG--
branch : trunk
2010-09-25 01:02:40 +02:00
Machiavelli 09aeff1027 Core/DBLayer: Return proper connection handle from DatabaseWorkerPool<T>::GetConnection
Updates issue #4062
Updates issue #4058

--HG--
branch : trunk
2010-09-24 22:41:24 +02:00
Machiavelli e3bf89b6f7 Core/DBLayer:
- Fix memory leak introduced in previous rev
- Fix linux compile, thanks to Playon for reporting

--HG--
branch : trunk
2010-09-24 22:36:35 +02:00
Machiavelli 3c6dc32030 Core/DBLayer:
- Rewrite Field class to be able to store both binary prepared statement data and data from adhoc query resultsets
- Buffer the data of prepared statements using ResultSet and Field classes and let go of mysql c api structures after PreparedResultSet constructor. Fixes a race condition and thus a possible crash/data corruption (issue pointed out to Derex, basic suggestion by raczman)
- Conform PreparedResultSet and ResultSet to the same design standards, and using Field class as data buffer class for both
* NOTE: This means the fetching methods are uniform again, using ¨Field* fields = result->Fetch();¨ and access to elements trough fields[x].
* NOTE: for access to the correct row in prepared statements, ¨Field* fields = result->Fetch();¨ must ALWAYS be called inside the do { }while(result->NextRow()) loop.
* NOTE: This means that Field::GetString() returns std::string object and Field::GetCString() returns const char* pointer.

Still experimental and all that jazz, not recommended for production servers until feedback is given.

--HG--
branch : trunk
2010-09-24 22:16:21 +02:00
Rat b46b498141 Core/ConditionMgr: revert CONDITION_GUID, can not be coded in current system without huge rewrites
--HG--
branch : trunk
2010-09-24 19:55:44 +02:00
Rat d2af10618f Core/ConditionMgr: added placeholder for CONDITION_GUID
renamed targetOverride to invoker
removed targetOverride code (had no use)

--HG--
branch : trunk
2010-09-24 18:16:29 +02:00
Spp b8cc05f747 Core/Opcodes: Re-enable error log for received opcodes marked as not allowed
--HG--
branch : trunk
2010-09-24 15:08:52 +02:00
Spp 9b56aadde1 Core/Opcodes: Add unhandled status, by balrok
--HG--
branch : trunk
2010-09-24 14:41:07 +02:00
Shauren 4a4d5fefae Core/Spells: Fixed damage boost part of Elemental Oath
Closes issue #4086.

--HG--
branch : trunk
2010-09-23 22:35:05 +02:00
Shauren 8a9f931184 Scripts/Icecrown Citadel: Fixed coldflame damage
Closes issue #3569.
Closes issue #3943.

--HG--
branch : trunk
2010-09-22 19:17:24 +02:00
azazel eae0e5c822 Scripts/DB_Scripts: massive cleanup of SCRIPT_COMMAND_* related staff
* add union into ScriptInfo structure (thanks NoFantasy for the idea);
* move scripts methods from Map.cpp to new file MapScripts.cpp;
* remove magic numbers and introduce eScriptFlags enumeration.

It's just a beginning and more changes to come. Stay tuned!

--HG--
branch : trunk
2010-09-22 18:13:57 +06:00
Shauren 562a8c272d Core/Items: Corrected logic in Item::CanBeTraded, fixes mailing and guild banks
--HG--
branch : trunk
2010-09-22 11:19:34 +02:00
silinoron 9ca1efa1e2 Core/Item: This ought to fix the crashes introduced in r2969543fa5
--HG--
branch : trunk
2010-09-21 19:56:33 -07:00
silinoron b21490357b Core/Object: Add an assert in Object::RemoveFlag to help explain the crash introduced in r2969543fa565b71242cb471e0e85f39203f2bce9
The crash is NOT fixed yet.

--HG--
branch : trunk
2010-09-21 19:26:59 -07:00
Rat 8b5369ff3f Core/ConditionMgr: only send special error msg if condition failed
--HG--
branch : trunk
2010-09-21 23:30:37 +02:00
Shauren d8ddf38453 Core/Items: Implemented trading soulbound loot items
Core/DBLayer: Converted more more player-related queries into prepared statements
Core/Items: Fixed loading of enchantments

Closes issue #4130.

--HG--
branch : trunk
2010-09-21 21:55:16 +02:00
azazel 5eb0fd80ac Scripts/Spells: move implementation of some spells into scripts.
* 41337 Aura of Anger
* 46394 Burn (Brutallus)
* 53302 Sniper Training
* 45472 Parachute
* 66118 Leeching Swarm
* 51685 Prey on the Weak
* 20911 Blessing of Sanctuary
* 25899 Greater Blessing of Sanctuary
Scripts/Spells: remove several spells implementations from core to table (requires DB data)
* 31231 Cheat Death
* 51662 Hunger for Blood

--HG--
branch : trunk
2010-09-21 23:59:45 +06:00
Shauren 38be7aab55 Core/Player: Fixed client crashes at login (issue introduced in revision 1c33354f20)
--HG--
branch : trunk
2010-09-21 16:16:58 +02:00
Spp 8ef673eda8 Core/Dungeon Finder: Check if system is enabled in some functions before doing anything else
--HG--
branch : trunk
2010-09-21 10:16:54 +02:00
Spp 7a3fd2e9bf Core/: Fix warnings
--HG--
branch : trunk
2010-09-21 10:11:25 +02:00
Shocker 63aa6e44fb Core/Scripts: Small, insignificant cleanups
--HG--
branch : trunk
2010-09-21 04:57:08 +03:00
Shocker eaadad5dfd Core/Arenas:
* Fix handling of Arena.ArenaStartPersonalRating
* Correct some typos for some arena configs in default world configuration file

--HG--
branch : trunk
2010-09-21 04:10:01 +03:00
Shocker 5ffaf0d84b Core/Commands: Implement command for adding (completing) achievements
--HG--
branch : trunk
2010-09-21 03:51:14 +03:00
Shocker 7b3d573a16 Adding "Stable" tag for r33dc0784b31f (9916), was tested thoroughly on a 1000+ realm and seems very stable
--HG--
branch : trunk
2010-09-21 01:00:35 +03:00
Rat 8e6ba6e7c9 Core/ConditionMgr: small cleanup, small fix
--HG--
branch : trunk
2010-09-20 22:11:55 +02:00
Rat cf93313316 Scripts/DB_Scripts: enable DB scripts to use CHAT_MSG_RAID_BOSS_WHISPER (42) as chat type
--HG--
branch : trunk
2010-09-20 21:58:14 +02:00
click f69c252f1d Buildsystem/Compilers: Adjust buildfiles slightly:
- Set SSE2 compile-flags only when used on 32-bit platforms (only used on x86 platforms, as x64 / Itanium has this as a standard)
- Clean up/merge some of the 64-bit/32-bit compiler options
- Clean up use of the PLATFORM variable (now sets PLATFORM 32 or PLATFORM 64, shaving off the CMAKE_SIZEOF_VOID_P test slightly)

--HG--
branch : trunk
2010-09-20 20:58:57 +02:00
Machiavelli ce2d4e9a20 Core/DBLayer: Correctly print relevant mysql prepared statement creation error to give the end-user an idea of what exactly went wrong (missing SQL updates are the culprit of creation failure 99% of the time)
--HG--
branch : trunk
2010-09-20 20:53:32 +02:00
Shauren a509976369 Core/DBLayer: Converted player login queries into prepared statements
Core/DBLayer: Added missing implementation for SQLQueryHolder::SetPreparedQuery

--HG--
branch : trunk
2010-09-20 18:20:40 +02:00
Spp cd40ab6776 Core/Dungeon Finder: Change all debug msgs to error.
--HG--
branch : trunk
2010-09-20 14:55:01 +02:00
Spp 33dc6b9d5f Core/Dungeon Finder: Multiple changes
- Code Style
- Explicit removal of the proposal if player leaves the queue (do not waits to ::Update)
- Force to leave LFG system if group/player is joining and its already in
- Change some debug msgs and fix some typos (error --> debug)
- Offer to continue: Remove duplicate checks
- Move body functions from .h to .cpp
- Revert 11e39d620d and check if group recently joined by comparing joinTimes

--HG--
branch : trunk
2010-09-20 14:06:21 +02:00
Spp 822421f625 Core: Fix some warnings:
- enumeration value ‘X’ not handled in switch
- unused parameter 'X'

--HG--
branch : trunk
2010-09-20 13:52:11 +02:00
Rat 2fb80e4a86 Core/ConditionMgr: You can now hide/show the quest marks with conditions (! ?)
note: check only runs at quest giver query!
Using together with CONDITION_SOURCE_TYPE_QUEST_ACCEPT you can totally hide quests

--HG--
branch : trunk
2010-09-20 10:19:20 +02:00
click 1d6d11d367 Core/CharHandler: Correction on SQL-statement - fixes logincrashes when testing for banned characters
--HG--
branch : trunk
2010-09-20 03:37:49 +02:00
silinoron 76e47fd795 Core/Unit: Cleanup; mostly purging a ton of dead code.
TODO: Move packet stuff out of Unit into packet handlers...

--HG--
branch : trunk
2010-09-19 17:08:14 -07:00
_manuel_ 524a584345 Core/Quests: Implemented new flags to QuestFlags enum.
--HG--
branch : trunk
2010-09-19 21:03:07 -03:00
silinoron 171fcfa963 Core/Unit: Do not allow game masters to be damaged.
--HG--
branch : trunk
2010-09-19 16:48:15 -07:00
click 7070ab49fe Contrib: make the GDB macro start logging a little bit earlier to catch the important bits
--HG--
branch : trunk
2010-09-19 19:52:12 +02:00
Rat 5de3183180 Core/ConditionMgr: You can now add conditions to QuestAccept (at CanTakeQuest check)
--HG--
branch : trunk
2010-09-19 19:49:23 +02:00
_manuel_ c4ed3430cf Core/Players: Better check for weekly quests in RewardQuest function.
--HG--
branch : trunk
2010-09-19 13:24:21 -03:00
click 58dafd94e2 BuildSystem/Platforms: Move platform-specific settings into respective directories, consistent with what is done with compilers.
BuildSystem/GCC: Add some additional parameters when using SFMT

--HG--
branch : trunk
2010-09-19 18:17:53 +02:00
click 54212cf387 Contrib: Add example GDB backtrace generator script and a small readme on how to use it - Note: DO read the README file before using.
(Allows for semi-automated crashreporting on GDB/*nix-based platforms with proper information included).

--HG--
branch : trunk
2010-09-19 18:11:03 +02:00