By sirikfoll updates #16921
If nothing else is needed on that ticket i will close it tomorrow.
(cherry picked from commit f9414654d1fad85383ef509a015c814d4f5f08de)
- removes Professor Dabiri from zone script and adds him to smart_scripts.
- also removes one more line of hardcoded text in core scripts
(cherry picked from commit 8e84603090726cf3715c444763a2c499f6518e95)
Closes#14692 by Tangol
Maybe there are some incorrect flags, open a ticket for affected bosses.
(cherry picked from commit 416a26b70c81946f1769e2741f4942cca9f7307f)
1) Venomhide Hatchling - add text emotes for when fed.
2) Silkwing Larva - Metamorphis into Silkwing.
3) Fix Rise, Obsidion, The Emissary and last 3 quests from Battle at Valhalas Chain again since previously using sai action to start attack would force remove immune_to_pc flags.
(cherry picked from commit 21430746b62be066d333bf511c8725b3460f0082)
(cherry picked from commit f03dc799591afe9421b1970fa9b07465bf6ef312)
Rename 9999_99_99_99_world.sql to 2016_06_13_04_world.sql
(cherry picked from commit 90ba7fe938241b6900daaef950e89b58da1e514f)
Closes#17342 by SnapperRy
(cherry picked from commit d4fbddfd7e7dce9343f95516bfaa9280887118e9)
DB/Quest: fix availability for quest "The Totem of Kar'dash"
Closes#17344 by SnapperRy
(cherry picked from commit 405b4edca5af86d27874eb94d451c749f12abf72)
By tkrokli
Closes#17334
(cherry picked from commit 951d0f579480773f4f9f2c9dca8ec0a97ac680a2)
DB/Quest: Improvements for quest "Bitter Rivals"
By SnapperRy
Closes #17267
(cherry picked from commit 16fa58176820a458eae0f7a2be1e527a33dd1d6b)
DB/SAI: Mebok Mizzyrix
By Rushor
(cherry picked from commit 51a34eb135b27061f49349ca6af35479fac773c7)
DB/SAI: Cabal Ritualists
By Malcrom
Closes #17212
(cherry picked from commit cc7adf9f9cf49633ba76b5ebc86e69af382ea839)
DB/Creature: RP event with Jane, Nova & Jessel
Closes#17164
By lyn1337
(cherry picked from commit cf398f2d2e946a91cebf791ebaac993ef890c283)
DB: Fix a DB error
(cherry picked from commit 88f1de12e42d6b1c21ca17f050a4b4d8172cf28d)
DB/Loot: Fix some drop rates
Closes#17139
(cherry picked from commit bd3bfc4ce127cdacb4b0e582609bf495bb6186ab)
DB/Creature: Add FLAG_EXTRA_NO_PLAYER_DAMAGE_REQ to some npcs
Closes#17045
(cherry picked from commit 777910141c187db5c241b98b558f65d5dc7d1cd3)
DB/Quest: Fix locales for Nessa Shadowsong quest
Closes#17345
(cherry picked from commit 0676622f4ea2d766f124211c99756a77d3376cf5)
Also make sure the creature is alive before updating.
Fixes#12823.
(cherry picked from commit 2db9269ec1c06b5fccc45dc0a5b4f714f9b48804)
DB/Creature: World Trigger (Not Immune NPC) InhabitType update
Closes#17332 by Malcrom
(cherry picked from commit 78d08834c0afe0be09e4ec071a6e6855aa18e2c8)
DB/Item: Fix text in Rune-Inscribed Parchment
Closes#17329 by tkrokli
(cherry picked from commit 8879545f21fe13650872358741b687a524cf8cb9)
DB/Quest: improve chaining for "The Ashenvale Hunt" quests
Closes#17323 by SnapperRy
(cherry picked from commit d034eedb811912546025d11a5e9335bcd6600464)
DB/trinity_string: wrong string about character customization + minor fix
Closes#17306 by lyn1337
(cherry picked from commit 0951e559ebe6b76abdfef55619244578d9917002)
DB/Quest: fix some completion/offer reward quest texts
Closes#17336 by SnapperRy
(cherry picked from commit e9025036b9848a5a684c57e3e066687c29fde321)
DB/Quest: add queststarters for "Regthar Deathgate"
Closes#17337 by SnapperRy
(cherry picked from commit 0b8921a0ef81fb7c4741248301b17a86fa0ffb69)
DB/Quest: fix chaining for "The Real Threat"
Closes#17338 by SnapperRy
(cherry picked from commit c9cb86d6c53ceb7331a1a5c1ff8a69f569cca426)
DB/Quest: fix repeatableness (or lack of) for some quests
Closes#17339 by SnapperRy
(cherry picked from commit b9f2e2a81b7f0a269da3a8f9597a4eca17899781)
DB/Quest: improvements for "Fool's Stout"
Closes#17340 by SnapperRy
(cherry picked from commit 4ec753dc50927e358a63a49a56cef7f5a72f41eb)
- remove hardcoded (and wrong) text from the script
- copy valid text from broadcast_text to gossip_menu_option
- gossip_menu / npc_text is already correct in TDB 335.61
- sort + clean up core script enum list and add new entries
- keep gossip handling unchanged in the script (low prio)
(cherry picked from commit 582af025090462f29576988e7a4517fee9a206fe)
Core/Scripts/DB: move npc_gregan_brewspewer to DB
- Remove npc_gregan_brewspewer, thereby removing hardcoded text
`#define GOSSIP_HELLO "Buy somethin', will ya?"`
- Move all gossip handling to DB (gossip texts already exist in TDB)
(cherry picked from commit 3acf6f36d1d60b7e2ac082bf9f6976de3256e250)
Core/Scripts: npc_grandmother gossip text moved to DB
Removing one more hardcoded text line from core scripts.
Also adding correct gossip to the npc_grandmother script.
Gossip changes in this script:
- remove hardcoded text from core script
- use existing npc_text IDs in gossip enum
- add missing text rows to gossip_menu_option
- use values from gossip_menu_option in enum
- replace spawn coordinates 0.0f with GetPosition()
(cherry picked from commit c214f987d730169e106b37fa1fe5f8565609374b)
Core/Scripts: remove hardcoded text from npc_locksmith
- remove hardcoded text from script
- move the gossip handling to DB SQL
- move the script conditions to DB SQL
- use correct gossip from broadcast_text
- remove options not existing in broadcast_text
- add Key to Searing Gorge option (related spell)
- add The Eye of Haramad option (related spell)
(cherry picked from commit e6ee6e2ae85f8a760dcd17e01b388bf3cd27c1e2)
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".
Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()
The scripted events are unchanged.
If the script is inaccurate, make a new PR.
(cherry picked from commit b6d43623a259f62ce0240a9e9f44f28e8c1ad5eb)
Aokromes