Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
(cherry picked from commit 2170541a51ced3c15675b8854e0ae49461884f8c)
Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6e53c7740862cae18840c9d399dda7f)
(cherry picked from commit 6d00d3f28380dd0811a18913450b1dc4f07fef48)
Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967fb3a430fbd54148c08b6d8e8937daac)
Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2ae3261e7fab249f4177900d4c8d013)
PCH build fix. Again.
(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241acf511467decd92d2a30e19927d74d)
- Fix yell on quest item use.
- Restore original entry on reset.
- Quest item can only be used on specific NPC.
(cherry picked from commit e2981e1060d8e2f764e5eaf28d57be508c42d5e0)
* Appeasing the Great Rainstone/Gods like Shiny Things update so sai actually works on sholazar guardians so sai runs on charmed creature, also rescript glinting dirt as previous had stopped working
* Teleport This! Charmed flags are needed here so that credit spell is cast when payer uses controlled npc to blow up teleporter.
* Updates to blueleaf tubers as previous fix stopped working due to negative respawn time on spell focus objects
(cherry picked from commit ebc0190d3b68555bfae4b2b1d2ea0409ef1035c7)
- Fix next quest for The Taunka and the Tauren.
- Fix requirements for Patience is a Virtue that We Don't Need, Taken by the Scourge and the three versions of The Defense of Warsong Hold.
(cherry picked from commit fd6cf2bca6fe7c6d80dfec1e9e310b3c3c499563)
- To Dragon's Fall requires completion of Wanted: Magister Keldonus, Wanted: Gigantaur and Wanted: Dreadtalon.
- Black Blood of Yogg-Saron, Marked for Death: High Cultist Zangus and Containing the Rot require completion of Agmar's Hammer.
- Strengthen the Ancients requires completion of The Focus on the Beach.
- Message from the West requires completion of Hellscream's Champion.
- Only one between A Tauren Among Taunka and The Taunka and the Tauren can be completed.
(cherry picked from commit b90afa88574b74a9b7524aaf875ff52bcafe426b)
- Victory Nears... requires Agmar's Hammer.
- Strength of Icemist requires From the Depths of Azjol-Nerub.
- Only one between To Venomspite! and Imbeciles Abound! can be completed.
(cherry picked from commit e07f68a032ae1f559296d99ec8b6e0982d6f8f79)
Prevents players from possibly getting permanently locked out of a whole quest chain in Dragonblight.
(cherry picked from commit 48203e2e257057921b24821ff0f9442cc6b15a43)
- Add missing texts and re-number the group ids.
- Do not allow players to attack the creatures spawned in the end event.
- A Score to Settle requires completion of this quest.
(cherry picked from commit c1129af75b2533c681b18193aaa3156458ab6b90)
The timed action lists for this script now need event flags so they run while charmed and so that Karsius actually gets summoned.
(cherry picked from commit 79578eab4063e77369659e120d484cd42e519766)
Rename 2016_09_14_03_world.sql to 2016_09_14_03_world.sql
(cherry picked from commit 6913286cb9a367321b9876c789d264a0dd4ed300)
Use ConditionTypeOrReference 45 (PetType in PetDefines.h):
- Show gossip menu 4783 option id 1 if Pet Type is hunter pet
( follow-up to PR #17746 / commit 03bafe3 )
(cherry picked from commit 9d7cd93e0da110546c5a572096773901c54c7f2b)
- Prevent player from entering combat when using the quest item.
- The targeted NPCs should only yell sporadically.
(cherry picked from commit 271c16fb60f7c0d3ada5d34e0dfc39eb8b1d2cb1)
Rename 2016_09_12_03_world.sql to 2016_09_13_01_world.sql
(cherry picked from commit 43968512ce88f0cbe37e23400437a753a84189ce)
Was easily exploitable for experience, since it's a wide instakill spell. Change confirmed from sniffs.
(cherry picked from commit 127825ee95214f67e217d9aff0c9683ff1aedfa8)
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
(cherry picked from commit 0479f08c3c07c4de3af4d2293b80d690e4bdf646)
Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!".
(cherry picked from commit 2f493430c9f029867eb1699c54de853e06e850d9)
Then use this new condition to fix Sniffing out the Perpetrator for Horde. Tagging issue #17914.
(cherry picked from commit 62cffd11d0e9b33dd60cb5238f06d6dfd06415d8)
This allows us to fix quest 12261 (No Place to Run). Closes#16291.
(cherry picked from commit e69a483aa942c1c6c4bd9b5fa47139f89643b8d5)
Derp. Build fix.
(cherry picked from commit 9180bcd404ff0a89144bbe834a2efe189bd0eb86)