Battlefields/WG: Refactored duplicated code

src/server/game/Battlefield/Zones/BattlefieldWG.cpp

@@ -452,17 +452,9 @@ void BattlefieldWG::OnBattleEnd(bool endbytimer)
     for (uint8 team = 0; team < 2; ++team)
     {
         for (GuidSet::const_iterator itr = m_PlayersInWar[team].begin(); itr != m_PlayersInWar[team].end(); ++itr)
-        {
             if (Player* player = sObjectAccessor->FindPlayer(*itr))
-            {
+                RemoveAurasFromPlayer(player);
-                player->RemoveAura(SPELL_TOWER_CONTROL);
+
-                player->RemoveAurasDueToSpell(SPELL_RECRUIT);
-                player->RemoveAurasDueToSpell(SPELL_CORPORAL);
-                player->RemoveAurasDueToSpell(SPELL_LIEUTENANT);
-                player->RemoveAurasDueToSpell(SPELL_TENACITY);
-                player->RemoveAurasDueToSpell(SPELL_SPIRITUAL_IMMUNITY);
-            }
-        }
                 m_PlayersInWar[team].clear();
 
         for (GuidSet::const_iterator itr = m_vehicles[team].begin(); itr != m_vehicles[team].end(); ++itr)
@@ -826,7 +818,7 @@ void BattlefieldWG::PromotePlayer(Player* killer)
     }
 }
 
-void BattlefieldWG::OnPlayerJoinWar(Player* player)
+void BattlefieldWG::RemoveAurasFromPlayer(Player* player)
 {
     player->RemoveAurasDueToSpell(SPELL_RECRUIT);
     player->RemoveAurasDueToSpell(SPELL_CORPORAL);
@@ -835,6 +827,12 @@ void BattlefieldWG::OnPlayerJoinWar(Player* player)
     player->RemoveAurasDueToSpell(SPELL_SPIRITUAL_IMMUNITY);
     player->RemoveAurasDueToSpell(SPELL_TENACITY);
     player->RemoveAurasDueToSpell(SPELL_ESSENCE_OF_WINTERGRASP);
+    player->RemoveAurasDueToSpell(SPELL_WINTERGRASP_RESTRICTED_FLIGHT_AREA);
+}
+
+void BattlefieldWG::OnPlayerJoinWar(Player* player)
+{
+    RemoveAurasFromPlayer(player);
 
     player->CastSpell(player, SPELL_RECRUIT, true);
 
@@ -875,15 +873,7 @@ void BattlefieldWG::OnPlayerLeaveWar(Player* player)
     {
         if (player->GetVehicle())                              // Remove vehicle of player if he go out.
             player->GetVehicle()->Dismiss();
-        player->RemoveAurasDueToSpell(SPELL_RECRUIT);
+        RemoveAurasFromPlayer(player);
-        player->RemoveAurasDueToSpell(SPELL_CORPORAL);
-        player->RemoveAurasDueToSpell(SPELL_LIEUTENANT);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
-        player->RemoveAurasDueToSpell(SPELL_SPIRITUAL_IMMUNITY);
-        player->RemoveAurasDueToSpell(SPELL_TENACITY);
-        player->RemoveAurasDueToSpell(SPELL_WINTERGRASP_RESTRICTED_FLIGHT_AREA);
-        player->RemoveAurasDueToSpell(SPELL_ESSENCE_OF_WINTERGRASP);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
     }
     player->RemoveAurasDueToSpell(SPELL_HORDE_CONTROLS_FACTORY_PHASE_SHIFT);
     player->RemoveAurasDueToSpell(SPELL_ALLIANCE_CONTROLS_FACTORY_PHASE_SHIFT);
@@ -893,18 +883,9 @@ void BattlefieldWG::OnPlayerLeaveWar(Player* player)
 
 void BattlefieldWG::OnPlayerLeaveZone(Player* player)
 {
-    player->RemoveAurasDueToSpell(SPELL_ESSENCE_OF_WINTERGRASP);
     if (!m_BattlefieldActive)
-    {
+        RemoveAurasFromPlayer(player);
-        player->RemoveAurasDueToSpell(SPELL_RECRUIT);
+       
-        player->RemoveAurasDueToSpell(SPELL_CORPORAL);
-        player->RemoveAurasDueToSpell(SPELL_LIEUTENANT);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
-        player->RemoveAurasDueToSpell(SPELL_SPIRITUAL_IMMUNITY);
-        player->RemoveAurasDueToSpell(SPELL_TENACITY);
-        player->RemoveAurasDueToSpell(SPELL_WINTERGRASP_RESTRICTED_FLIGHT_AREA);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
-    }
     player->RemoveAurasDueToSpell(SPELL_HORDE_CONTROLS_FACTORY_PHASE_SHIFT);
     player->RemoveAurasDueToSpell(SPELL_ALLIANCE_CONTROLS_FACTORY_PHASE_SHIFT);
     player->RemoveAurasDueToSpell(SPELL_HORDE_CONTROL_PHASE_SHIFT);
@@ -913,20 +894,8 @@ void BattlefieldWG::OnPlayerLeaveZone(Player* player)
 
 void BattlefieldWG::OnPlayerEnterZone(Player* player)
 {
-    player->RemoveAurasDueToSpell(SPELL_ESSENCE_OF_WINTERGRASP);
     if (!m_BattlefieldActive)
-    {
+        RemoveAurasFromPlayer(player);
-        player->RemoveAurasDueToSpell(SPELL_RECRUIT);
-        player->RemoveAurasDueToSpell(SPELL_CORPORAL);
-        player->RemoveAurasDueToSpell(SPELL_LIEUTENANT);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
-        player->RemoveAurasDueToSpell(SPELL_SPIRITUAL_IMMUNITY);
-        player->RemoveAurasDueToSpell(SPELL_TENACITY);
-        player->RemoveAurasDueToSpell(SPELL_WINTERGRASP_RESTRICTED_FLIGHT_AREA);
-        player->RemoveAurasDueToSpell(SPELL_TOWER_CONTROL);
-        if (player->GetTeamId() == GetDefenderTeam())
-            player->AddAura(SPELL_ESSENCE_OF_WINTERGRASP, player);
-    }
 
     player->AddAura(m_DefenderTeam == TEAM_HORDE ? SPELL_HORDE_CONTROL_PHASE_SHIFT : SPELL_ALLIANCE_CONTROL_PHASE_SHIFT, player);
     // Send worldstate to player

src/server/game/Battlefield/Zones/BattlefieldWG.h

@@ -384,19 +384,21 @@ class BattlefieldWG : public Battlefield
 
         void DoCompleteOrIncrementAchievement(uint32 achievement, Player *player, uint8 incrementNumber = 1);
         
+        void RemoveAurasFromPlayer(Player* player);
+
         /**
          * \brief Called when battlefield is setup, at server start
          */
         bool SetupBattlefield();
 
         /// Return pointer to relic object
-        GameObject *GetRelic()
+        GameObject* GetRelic()
         {
             return m_relic;
         }
 
         /// Define relic object
-        void SetRelic(GameObject * relic)
+        void SetRelic(GameObject* relic)
         {
             m_relic = relic;
         }