Core/: Fix warnings

--HG--
branch : trunk

src/genrevision/genrevision.cpp

@@ -22,8 +22,6 @@
 #include <stdio.h>
 #include <string.h>
 
-#pragma warning(disable:4996)
-
 std::string build_directive = "Unknown";
 
 struct RawData
@@ -110,25 +108,43 @@ void extractDataFromArchive(FILE* EntriesFile, std::string /*path*/, bool /*url*
     char latesttag_str[200];
     char latesttagdistance_str[200];
 
-    fgets(buf,200,EntriesFile);
+    bool error = true;
+    if (fgets(buf,200,EntriesFile))
+    {
         sscanf(buf,"repo: %s",repo_str);
-    fgets(buf,200,EntriesFile);
+        if (fgets(buf,200,EntriesFile))
+        {
             sscanf(buf,"node: %s",hash_str);
-    fgets(buf,200,EntriesFile);
+            if (fgets(buf,200,EntriesFile))
+            {
                 sscanf(buf,"branch: %s",branch_str);
-    fgets(buf,200,EntriesFile);
+                if (fgets(buf,200,EntriesFile))
+                {
                     sscanf(buf,"latesttag: %[^\n]",latesttag_str);
-    fgets(buf,200,EntriesFile);
+                    if (fgets(buf,200,EntriesFile))
+                    {
                         sscanf(buf,"latesttagdistance: %s",latesttagdistance_str);
+                        error = false;
+                    }
+                }
+            }
+        }
+    }
 
+    if (!error)
+    {
         char thash_str[200];
         for (int i = 11; i >= 0; --i)
-    {
             thash_str[i] = hash_str[i];
-    }
         thash_str[12] = '\0';
         strcpy(data.hash_str,thash_str);
         strcpy(data.rev_str,"Archive");
+    }
+    else
+    {
+        strcpy(data.hash_str,"*");
+        strcpy(data.rev_str,"*");
+    }
 
     strcpy(data.date_str,"*");
     strcpy(data.time_str,"*");

src/server/game/AI/SmartAI/SmartAI.cpp

@@ -44,7 +44,7 @@ int SmartAI::Permissible(const Creature *creature)
     return PERMIT_BASE_NO;
 }
 
-void SmartAI::UpdateAI(const uint32 diff)
+void SmartAI::UpdateAI(const uint32 /*diff*/)
 {
 }
 
@@ -60,7 +60,7 @@ void SmartAI::JustReachedHome()
 {
 }
 
-void SmartAI::EnterCombat(Unit *enemy)
+void SmartAI::EnterCombat(Unit* /*enemy*/)
 {
 }
 
@@ -68,15 +68,15 @@ void SmartAI::EnterEvadeMode()
 {
 }
 
-void SmartAI::JustDied(Unit* killer)
+void SmartAI::JustDied(Unit* /*killer*/)
 {
 }
 
-void SmartAI::KilledUnit(Unit* victim)
+void SmartAI::KilledUnit(Unit* /*victim*/)
 {
 }
 
-void SmartAI::JustSummoned(Creature* pUnit)
+void SmartAI::JustSummoned(Creature* /*pUnit*/)
 {
 }
 
@@ -86,56 +86,56 @@ void SmartAI::AttackStart(Unit *who)
         me->GetMotionMaster()->MoveChase(who);
 }
 
-void SmartAI::MoveInLineOfSight(Unit *who)
+void SmartAI::MoveInLineOfSight(Unit* /*who*/)
 {
     //CanAIAttack
 }
 
-void SmartAI::SpellHit(Unit* pUnit, const SpellEntry* pSpell)
+void SmartAI::SpellHit(Unit* /*pUnit*/, const SpellEntry* /*pSpell*/)
 {
 }
 
-void SmartAI::SpellHitTarget(Unit* target, const SpellEntry*)
+void SmartAI::SpellHitTarget(Unit* /*target*/, const SpellEntry* /*pSpell*/)
 {
 }
 
-void SmartAI::DamageTaken(Unit* done_by, uint32& damage)
+void SmartAI::DamageTaken(Unit* /*done_by*/, uint32& /*damage*/)
 {
 }
 
-void SmartAI::HealReceived(Unit* done_by, uint32& addhealth)
+void SmartAI::HealReceived(Unit* /*done_by*/, uint32& /*addhealth*/)
 {
 }
 
-void SmartAI::ReceiveEmote(Player* pPlayer, uint32 text_emote)
+void SmartAI::ReceiveEmote(Player* /*pPlayer*/, uint32 /*text_emote*/)
 {
 }
 
-void SmartAI::MovementInform(uint32 MovementType, uint32 Data)
+void SmartAI::MovementInform(uint32 /*MovementType*/, uint32 /*Data*/)
 {
 }
 
-void SmartAI::IsSummonedBy(Unit* summoner)
+void SmartAI::IsSummonedBy(Unit* /*summoner*/)
 {
 }
 
-void SmartAI::DamageDealt(Unit * done_to, uint32 & damage)
+void SmartAI::DamageDealt(Unit* /*done_to*/, uint32& /*damage*/)
 {
 }
 
-void SmartAI::SummonedCreatureDespawn(Creature* unit)
+void SmartAI::SummonedCreatureDespawn(Creature* /*unit*/)
 {
 }
 
-void SmartAI::UpdateAIWhileCharmed(const uint32 diff)
+void SmartAI::UpdateAIWhileCharmed(const uint32 /*diff*/)
 {
 }
 
-void SmartAI::CorpseRemoved(uint32 & respawnDelay)
+void SmartAI::CorpseRemoved(uint32& /*respawnDelay*/)
 {
 }
 
-void SmartAI::PassengerBoarded(Unit* who, int8 seatId, bool apply)
+void SmartAI::PassengerBoarded(Unit* /*who*/, int8 /*seatId*/, bool /*apply*/)
 {
 }
 
@@ -143,49 +143,49 @@ void SmartAI::InitializeAI()
 {
 }
 
-void SmartAI::OnCharmed(bool apply)
+void SmartAI::OnCharmed(bool /*apply*/)
 {
 }
 
-bool SmartAI::CanAIAttack(const Unit* who) const
+bool SmartAI::CanAIAttack(const Unit* /*who*/) const
 {
     return true;
 }
 
-void SmartAI::DoAction(const int32 param)
+void SmartAI::DoAction(const int32 /*param*/)
 {
 }
 
-uint32 SmartAI::GetData(uint32 id)
+uint32 SmartAI::GetData(uint32 /*id*/)
 {
     return 0;
 }
 
-void SmartAI::SetData(uint32 id, uint32 value)
+void SmartAI::SetData(uint32 /*id*/, uint32 /*value*/)
 {
 }
 
-void SmartAI::SetGUID(const uint64 &guid, int32 id)
+void SmartAI::SetGUID(const uint64& /*guid*/, int32 /*id*/)
 {
 }
 
-uint64 SmartAI::GetGUID(int32 id)
+uint64 SmartAI::GetGUID(int32 /*id*/)
 {
     return 0;
 }
 
-void SmartAI::MovepointReached(uint32 id)
+void SmartAI::MovepointReached(uint32 /*id*/)
 {
 }
 
-void SmartAI::MovepointStart(uint32 id)
+void SmartAI::MovepointStart(uint32 /*id*/)
 {
 }
 
-void SmartAI::SetRun(bool run)
+void SmartAI::SetRun(bool /*run*/)
 {
 }
 
-void SmartAI::SetMovePathEndAction(SMARTAI_ACTION action)
+void SmartAI::SetMovePathEndAction(SMARTAI_ACTION /*action*/)
 {
 }

src/server/game/Entities/Player/Player.cpp

@@ -16875,7 +16875,7 @@ void Player::_LoadInventory(PreparedQueryResult result, uint32 timediff)
                 else
                 {
                     Field* fields2 = result2->Fetch();
-                    std::string strGUID = fields[2].GetString();
+                    std::string strGUID = fields2[0].GetString();
                     Tokens GUIDlist = StrSplit(strGUID, " ");
                     AllowedLooterSet looters;
                     for (Tokens::iterator itr = GUIDlist.begin(); itr != GUIDlist.end(); ++itr)

src/server/game/Texts/CreatureTextMgr.cpp

@@ -109,7 +109,7 @@ void CreatureTextMgr::LoadCreatureTexts()
     sLog.outString(">> Loaded %u Creature Texts for %u Creatures.", TextCount, CreatureCount);
 }
 
-void CreatureTextMgr::SendChat(Creature* source, uint8 textGroup, uint64 whisperGuid, ChatType msgtype, Language language, TextRange range)
+void CreatureTextMgr::SendChat(Creature* source, uint8 textGroup, uint64 whisperGuid, ChatType /*msgtype*/, Language /*language*/, TextRange /*range*/)
 {
     if (!source)
         return;

src/server/scripts/Spells/spell_hunter.cpp

@@ -343,7 +343,7 @@ public:
 
     class spell_hun_sniper_training_AuraScript : public AuraScript
     {
-        bool Validate(SpellEntry const * entry)
+        bool Validate(SpellEntry const * /*entry*/)
         {
             if (!sSpellStore.LookupEntry(SPELL_SNIPER_TRAINING_R1))
                 return false;

src/server/scripts/Spells/spell_paladin.cpp

@@ -99,7 +99,7 @@ public:
 
     class spell_pal_blessing_of_sanctuary_AuraScript : public AuraScript
     {
-        bool Validate(SpellEntry const * entry)
+        bool Validate(SpellEntry const* /*entry*/)
         {
             if (!sSpellStore.LookupEntry(PALADIN_SPELL_BLESSING_OF_SANCTUARY_BUFF))
                 return false;

src/server/shared/Database/QueryResult.cpp

@@ -22,24 +22,24 @@
 #include "Log.h"
 
 ResultSet::ResultSet(MYSQL_RES *result, MYSQL_FIELD *fields, uint64 rowCount, uint32 fieldCount) :
-m_result(result),
-m_fields(fields),
 m_rowCount(rowCount),
-m_fieldCount(fieldCount)
+m_fieldCount(fieldCount),
+m_result(result),
+m_fields(fields)
 {
     m_currentRow = new Field[m_fieldCount];
     ASSERT(m_currentRow);
 }
 
 PreparedResultSet::PreparedResultSet(MYSQL_STMT* stmt, MYSQL_RES *result, uint64 rowCount, uint32 fieldCount) :
+m_rowCount(rowCount),
+m_rowPosition(0),
+m_fieldCount(fieldCount),
 m_rBind(NULL),
 m_stmt(stmt),
 m_res(result),
 m_isNull(NULL),
-m_length(NULL),
-m_rowCount(rowCount),
-m_fieldCount(fieldCount),
-m_rowPosition(0)
+m_length(NULL)
 {
     if (!m_res)
         return;

src/server/worldserver/Master.cpp

@@ -146,7 +146,6 @@ public:
         // Launch the RA listener socket
         ListenSocket<RASocket> RAListenSocket (h);
         bool usera = sConfig.GetBoolDefault ("Ra.Enable", false);
-        bool needInit = true;
 
         if (usera)
         {