*Thread safe player searcher in scripts.

--HG--
branch : trunk

src/server/game/AI/ScriptedAI/ScriptedFollowerAI.cpp

@@ -309,7 +309,7 @@ void FollowerAI::StartFollow(Player* pLeader, uint32 uiFactionForFollower, const
 
 Player* FollowerAI::GetLeaderForFollower()
 {
-    if (Player* pLeader = Unit::GetPlayer(m_uiLeaderGUID))
+    if (Player* pLeader = Unit::GetPlayer(*me, m_uiLeaderGUID))
     {
         if (pLeader->isAlive())
             return pLeader;

src/server/game/Entities/Unit/Unit.cpp

@@ -12851,9 +12851,9 @@ Unit* Unit::GetUnit(WorldObject& object, uint64 guid)
     return ObjectAccessor::GetUnit(object,guid);
 }
 
-Player* Unit::GetPlayer(uint64 guid)
+Player* Unit::GetPlayer(WorldObject& object, uint64 guid)
 {
-    return ObjectAccessor::FindPlayer(guid);
+    return ObjectAccessor::GetPlayer(object,guid);
 }
 
 Creature* Unit::GetCreature(WorldObject& object, uint64 guid)

src/server/game/Entities/Unit/Unit.h

@@ -1868,7 +1868,7 @@ class Unit : public WorldObject
         void addFollower(FollowerReference* pRef) { m_FollowingRefManager.insertFirst(pRef); }
         void removeFollower(FollowerReference* /*pRef*/) { /* nothing to do yet */ }
         static Unit* GetUnit(WorldObject& object, uint64 guid);
-        static Player* GetPlayer(uint64 guid);
+        static Player* GetPlayer(WorldObject& object, uint64 guid);
         static Creature* GetCreature(WorldObject& object, uint64 guid);
 
         MotionMaster* GetMotionMaster(){ return &i_motionMaster; }

src/server/game/Spells/Auras/SpellAuras.cpp

@@ -1651,6 +1651,9 @@ void UnitAura::FillTargetMap(std::map<Unit *, uint8> & targets, Unit * caster)
 DynObjAura::DynObjAura(SpellEntry const* spellproto, uint8 effMask, WorldObject * owner, Unit * caster, int32 *baseAmount, Item * castItem, uint64 casterGUID)
     : Aura(spellproto, effMask, owner, caster, baseAmount, castItem, casterGUID)
 {
+    ASSERT(GetDynobjOwner());
+    ASSERT(GetDynobjOwner()->IsInWorld());
+    ASSERT(GetDynobjOwner()->GetMap() == caster->GetMap());
     GetDynobjOwner()->SetAura(this);
 }
 

src/server/game/Spells/SpellEffects.cpp

@@ -351,7 +351,7 @@ void Spell::SpellDamageSchoolDmg(uint32 effect_idx)
                             uint8 count = 0;
                             for (std::list<TargetInfo>::iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit)
                                 if (ihit->targetGUID != m_caster->GetGUID())
-                                    if (Player *target = ObjectAccessor::FindPlayer(ihit->targetGUID))
+                                    if (Player *target = ObjectAccessor::GetPlayer(*m_caster, ihit->targetGUID))
                                         if (target->HasAura(m_triggeredByAuraSpell->Id))
                                             ++count;
                             if (count)