Core: Fix some warnings

--HG--
branch : trunk

src/server/game/DungeonFinding/LFGMgr.cpp

@@ -2135,7 +2135,6 @@ LfgReward const* LFGMgr::GetRandomDungeonReward(uint32 dungeon, uint8 level)
 {
     LfgReward const* rew = NULL;
     LfgRewardMapBounds bounds = m_RewardMap.equal_range(dungeon & 0x00FFFFFF);
-    uint8 index = 0;
     for (LfgRewardMap::const_iterator itr = bounds.first; itr != bounds.second; ++itr)
     {
         rew = itr->second;
@@ -2199,4 +2198,4 @@ std::string LFGMgr::ConcatenateGuids(LfgGuidList check)
         o << "|" << *it;
     guidSet.clear();
     return o.str();
-}
+}

src/server/game/DungeonFinding/LFGMgr.h

@@ -275,7 +275,7 @@ class LFGMgr
         void LoadDungeonEncounters();
         void LoadRewards();
         void RewardDungeonDoneFor(const uint32 dungeonId, Player* player);
-        const uint32 GetDungeonIdForAchievement(uint32 achievementId)
+        uint32 GetDungeonIdForAchievement(uint32 achievementId)
         {
             std::map<uint32, uint32>::iterator itr = m_EncountersByAchievement.find(achievementId);
             if (itr != m_EncountersByAchievement.end())

src/server/game/Entities/Unit/Unit.cpp

@@ -101,8 +101,8 @@ static bool procPrepared = InitTriggerAuraData();
 Unit::Unit(): WorldObject(),
 m_movedPlayer(NULL), IsAIEnabled(false), NeedChangeAI(false), 
 m_ControlledByPlayer(false), i_AI(NULL), i_disabledAI(NULL), m_procDeep(0), 
-m_removedAurasCount(0),  m_vehicle(NULL), m_vehicleKit(NULL), m_unitTypeMask(UNIT_MASK_NONE),
-m_ThreatManager(this), i_motionMaster(this), m_HostileRefManager(this)
+m_removedAurasCount(0),  m_vehicle(NULL), i_motionMaster(this), m_vehicleKit(NULL),
+m_ThreatManager(this), m_unitTypeMask(UNIT_MASK_NONE), m_HostileRefManager(this)
 {
 #ifdef _MSC_VER
 #pragma warning(default:4355)

src/server/game/Scripting/ScriptMgr.h

@@ -686,7 +686,7 @@ public:
     virtual void OnTextEmote(Player* /*player*/, uint32 /*text_emote*/, uint32 /*emoteNum*/, uint64 /*guid*/) { }
 
     // Called in Spell::cast
-    virtual void OnSpellCast(Player *player, Spell *spell, bool skipCheck) { }
+    virtual void OnSpellCast(Player * /*player*/, Spell * /*spell*/, bool /*skipCheck*/) { }
 };
 
 class GuildScript : public ScriptObject