josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Logging: Fixed a possible crash with dynamic log file names

Browse Source
This commit is contained in:
Shauren
2012-08-09 14:31:09 +02:00
parent 78fdeca851
commit ca0a54f357
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/shared/Logging/Appender.h
+1 -1
View File
@@ -139,7 +139,7 @@ class Appender
static const char* getLogFilterTypeString(LogFilterType type); static const char* getLogFilterTypeString(LogFilterType type);
private: private:
virtual void _write(LogMessage& /*message*/) {}; virtual void _write(LogMessage& /*message*/) = 0;
uint8 id; uint8 id;
std::string name; std::string name;
src/server/shared/Logging/AppenderFile.cpp
+4 -1
View File
@@ -26,7 +26,7 @@ AppenderFile::AppenderFile(uint8 id, std::string const& name, LogLevel level, co
{ {
dynamicName = std::string::npos != filename.find("%u"); dynamicName = std::string::npos != filename.find("%u");
backup = _flags & APPENDER_FLAGS_MAKE_FILE_BACKUP; backup = _flags & APPENDER_FLAGS_MAKE_FILE_BACKUP;
logfile = !dynamicName ? OpenFile(_filename, _mode, backup) : NULL; logfile = !dynamicName ? OpenFile(_filename, _mode, backup) : NULL;
} }
@@ -54,7 +54,10 @@ void AppenderFile::_write(LogMessage& message)
fflush(logfile); fflush(logfile);
if (dynamicName) if (dynamicName)
{
fclose(logfile); fclose(logfile);
logfile = NULL;
}
} }
} }