Core: Remove lots warnings:

- All "'xxx' will be initialized after 'yyy' when initialized here"
- Some "unused variable"
- Some "enumeration value 'xxx' not handled in switch"

--HG--
branch : trunk

src/server/game/Server/WorldSession.cpp

@@ -46,11 +46,14 @@
 #include "Transport.h"
 
 /// WorldSession constructor
-WorldSession::WorldSession(uint32 id, WorldSocket *sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter) :
-m_muteTime(mute_time), _player(NULL), m_Socket(sock),_security(sec), _accountId(id), m_expansion(expansion),
-m_sessionDbcLocale(sWorld.GetAvailableDbcLocale(locale)), m_sessionDbLocaleIndex(sObjectMgr.GetIndexForLocale(locale)),
-_logoutTime(0), m_inQueue(false), m_playerLoading(false), m_playerLogout(false), m_playerRecentlyLogout(false), m_playerSave(false),
-m_latency(0), m_TutorialsChanged(false), m_timeOutTime(0), recruiterId(recruiter)
+WorldSession::WorldSession(uint32 id, WorldSocket *sock, AccountTypes sec, uint8 expansion, time_t mute_time, LocaleConstant locale, uint32 recruiter):
+m_muteTime(mute_time), m_timeOutTime(0), _player(NULL), m_Socket(sock),
+_security(sec), _accountId(id), m_expansion(expansion), _logoutTime(0),
+m_inQueue(false), m_playerLoading(false), m_playerLogout(false),
+m_playerRecentlyLogout(false), m_playerSave(false),
+m_sessionDbcLocale(sWorld.GetAvailableDbcLocale(locale)),
+m_sessionDbLocaleIndex(sObjectMgr.GetIndexForLocale(locale)),
+m_latency(0), m_TutorialsChanged(false), recruiterId(recruiter)
 {
     if (sock)
     {
@@ -1012,4 +1015,4 @@ void WorldSession::ProcessQueryCallbacks()
         HandleAddIgnoreOpcodeCallBack(result);
         m_addIgnoreCallback.cancel();
     }
-}
+}

src/server/game/Server/WorldSocket.cpp

@@ -100,18 +100,11 @@ struct ClientPktHeader
 #pragma pack(pop)
 #endif
 
-WorldSocket::WorldSocket (void) :
-WorldHandler(),
-m_Session(0),
-m_RecvWPct(0),
-m_RecvPct(),
-m_Header(sizeof (ClientPktHeader)),
-m_OutBuffer(0),
-m_OutBufferSize(65536),
-m_OutActive(false),
-m_Seed(static_cast<uint32> (rand32())),
-m_OverSpeedPings(0),
-m_LastPingTime(ACE_Time_Value::zero)
+WorldSocket::WorldSocket (void): WorldHandler(),
+m_LastPingTime(ACE_Time_Value::zero), m_OverSpeedPings(0), m_Session(0),
+m_RecvWPct(0), m_RecvPct(), m_Header(sizeof (ClientPktHeader)),
+m_OutBuffer(0), m_OutBufferSize(65536), m_OutActive(false),
+m_Seed(static_cast<uint32> (rand32()))
 {
     reference_counting_policy().value (ACE_Event_Handler::Reference_Counting_Policy::ENABLED);
 

src/server/game/Server/WorldSocketMgr.cpp

@@ -238,8 +238,8 @@ class ReactorRunnable : protected ACE_Task_Base
 };
 
 WorldSocketMgr::WorldSocketMgr() :
-    m_NetThreadsCount(0),
     m_NetThreads(0),
+    m_NetThreadsCount(0),
     m_SockOutKBuff(-1),
     m_SockOutUBuff(65536),
     m_UseNoDelay(true),