[8009] Pass const string reference to functions where possible. Author: hunuza

Avoids creating an unnecessary copy of strings.

--HG--
branch : trunk

src/game/Unit.cpp

@@ -12196,7 +12196,7 @@ void CharmInfo::SetPetNumber(uint32 petnumber, bool statwindow)
         m_unit->SetUInt32Value(UNIT_FIELD_PETNUMBER, 0);
 }
 
-void CharmInfo::LoadPetActionBar( std::string data )
+void CharmInfo::LoadPetActionBar(const std::string& data )
 {
     InitPetActionBar();
 

src/game/Unit.h

@@ -931,7 +931,7 @@ struct CharmInfo
                                                             //return true if successful
         bool AddSpellToActionBar(uint32 spellid, ActiveStates newstate = ACT_DECIDE);
         bool RemoveSpellFromActionBar(uint32 spell_id);
-        void LoadPetActionBar(std::string data);
+        void LoadPetActionBar(const std::string& data);
         void BuildActionBar(WorldPacket* data);
         void SetSpellAutocast(uint32 spell_id, bool state);
         void SetActionBar(uint8 index, uint32 spellOrAction,ActiveStates type)

src/game/World.h

@@ -452,7 +452,7 @@ class World
         void SetAllowMovement(bool allow) { m_allowMovement = allow; }
 
         /// Set a new Message of the Day
-        void SetMotd(std::string motd) { m_motd = motd; }
+        void SetMotd(const std::string& motd) { m_motd = motd; }
         /// Get the current Message of the Day
         const char* GetMotd() const { return m_motd.c_str(); }
 

src/game/WorldSession.h

@@ -60,7 +60,7 @@ struct AccountData
 
 struct AddonInfo
 {
-    AddonInfo(std::string name, uint8 enabled, uint32 crc)
+    AddonInfo(const std::string& name, uint8 enabled, uint32 crc)
     {
         Name = name;
         Enabled = enabled;