josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Metric: Log Map::Update() times (#25067)

Browse Source 
* Core/Metric: Log Map::Update() times

* Add more performant version to reduce allocations when metrics are disabled

* Linux build fix

* Add metric stopwatch version that doesnt let users forget to _END it

* Fix linux build

* Code cleanup

* Add Map updates panel to General dashboard

* Add "Recent events" panel to General dashboard

* Apply latest codestyle changes

Co-authored-by: Shauren <[email protected]>
(cherry picked from commit 5eb742ee6a892b684b0c4cbde9f02f838b8300e5)
This commit is contained in:
Giacomo Pozzoni
2022-01-23 21:36:28 +01:00
committed by Shauren
parent d11c3807b3
commit 8834c5c724
4 changed files with 272 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
contrib/grafana/1_General.json
+231 -12
View File
@@ -28,7 +28,7 @@
"gnetId": null,
"graphTooltip": 0,
"id": 5,
"iteration": 1592337582972,
"iteration": 1595020261725,
"links": [],
"panels": [
{
@@ -57,6 +57,12 @@
"thresholdLabels": false,
"thresholdMarkers": true
},
"gridPos": {
"h": 3,
"w": 4,
"x": 0,
"y": 0
},
"hideTimeOverride": false,
"id": 5,
"interval": null,
@@ -176,8 +182,8 @@
},
"gridPos": {
"h": 3,
"w": 6,
"x": 6,
"w": 5,
"x": 4,
"y": 0
},
"id": 6,
@@ -303,8 +309,8 @@
},
"gridPos": {
"h": 3,
"w": 6,
"x": 12,
"w": 5,
"x": 9,
"y": 0
},
"id": 7,
@@ -430,8 +436,8 @@
},
"gridPos": {
"h": 3,
"w": 6,
"x": 18,
"w": 5,
"x": 14,
"y": 0
},
"id": 8,
@@ -490,6 +496,8 @@
"measurement": "update_time_diff",
"orderByTime": "ASC",
"policy": "default",
"query": "SELECT mean(\"value\") FROM \"update_time_diff\" WHERE (\"realm\" =~ /^$realm$/) AND $timeFilter GROUP BY time($__interval) fill(null)",
"rawQuery": true,
"refId": "A",
"resultFormat": "time_series",
"select": [
@@ -530,6 +538,74 @@
],
"valueName": "avg"
},
{
"datasource": null,
"fieldConfig": {
"defaults": {
"custom": {}
},
"overrides": []
},
"gridPos": {
"h": 3,
"w": 5,
"x": 19,
"y": 0
},
"id": 12,
"options": {
"showLabels": false,
"showTime": true,
"sortOrder": "Descending",
"wrapLogMessage": true
},
"targets": [
{
"groupBy": [],
"measurement": "events",
"orderByTime": "ASC",
"policy": "default",
"query": "SELECT \"title\" FROM \"events\" WHERE (\"realm\" =~ /^$realm$/) order by \"time\" desc limit 2",
"rawQuery": true,
"refId": "A",
"resultFormat": "table",
"select": [
[
{
"params": [
"title"
],
"type": "field"
},
{
"params": [],
"type": "last"
}
]
],
"tags": []
}
],
"timeFrom": null,
"timeShift": null,
"title": "Recent events",
"transformations": [
{
"id": "organize",
"options": {
"excludeByName": {
"title": false
},
"indexByName": {},
"renameByName": {
"Time": "",
"title": ""
}
}
}
],
"type": "logs"
},
{
"aliasColors": {},
"bars": false,
@@ -606,8 +682,10 @@
}
],
"measurement": "update_time_diff",
"orderByTime": "ASC",
"policy": "default",
"query": "SELECT mean(\"value\") FROM \"update_time_diff\" WHERE \"realm\" =~ /$realm$/ AND $timeFilter GROUP BY time($interval) fill(null)",
"query": "SELECT max(\"value\") FROM \"update_time_diff\" WHERE (\"realm\" =~ /$realm$/) AND $timeFilter GROUP BY time($interval) fill(null)",
"rawQuery": false,
"refId": "A",
"resultFormat": "time_series",
"select": [
@@ -620,7 +698,7 @@
},
{
"params": [],
"type": "mean"
"type": "max"
}
]
],
@@ -659,6 +737,14 @@
"short"
],
"yaxes": [
{
"format": "ms",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": true
},
{
"format": "short",
"label": null,
@@ -666,6 +752,139 @@
"max": null,
"min": null,
"show": true
}
],
"yaxis": {
"align": false,
"alignLevel": null
}
},
{
"aliasColors": {},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": null,
"fieldConfig": {
"defaults": {
"custom": {}
},
"overrides": []
},
"fill": 1,
"fillGradient": 0,
"gridPos": {
"h": 8,
"w": 24,
"x": 0,
"y": 10
},
"hiddenSeries": false,
"id": 10,
"legend": {
"avg": false,
"current": false,
"hideEmpty": false,
"hideZero": true,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 2,
"nullPointMode": "connected",
"options": {
"dataLinks": []
},
"percentage": false,
"pointradius": 2,
"points": false,
"renderer": "flot",
"seriesOverrides": [],
"spaceLength": 10,
"stack": false,
"steppedLine": false,
"targets": [
{
"alias": "Map $tag_map_id",
"groupBy": [
{
"params": [
"$__interval"
],
"type": "time"
},
{
"params": [
"map_id"
],
"type": "tag"
},
{
"params": [
"none"
],
"type": "fill"
}
],
"measurement": "map_update_time_diff",
"orderByTime": "ASC",
"policy": "default",
"query": "SELECT max(\"value\") FROM \"map_update_time_diff\" WHERE (\"realm\" =~ /^$realm$/) AND $timeFilter GROUP BY time($__interval), \"map_id\" fill(none)",
"rawQuery": false,
"refId": "A",
"resultFormat": "time_series",
"select": [
[
{
"params": [
"value"
],
"type": "field"
},
{
"params": [],
"type": "max"
}
]
],
"tags": [
{
"key": "realm",
"operator": "=~",
"value": "/^$realm$/"
}
]
}
],
"thresholds": [],
"timeFrom": null,
"timeRegions": [],
"timeShift": null,
"title": "Map update",
"tooltip": {
"shared": true,
"sort": 0,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": []
},
"yaxes": [
{
"format": "ms",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": true
},
{
"format": "short",
@@ -709,7 +928,7 @@
"h": 7,
"w": 24,
"x": 0,
"y": 10
"y": 18
},
"hiddenSeries": false,
"id": 4,
@@ -860,7 +1079,7 @@
"h": 7,
"w": 24,
"x": 0,
"y": 17
"y": 25
},
"hiddenSeries": false,
"id": 3,
@@ -1096,5 +1315,5 @@
"timezone": "browser",
"title": "General info",
"uid": "BfuPZmZMz",
"version": 1
"version": 3
}