Core: Cleaning up hungarian notation - Phase3: pTarget -> target
This commit is contained in:
@@ -155,8 +155,8 @@ public:
|
||||
//Cast Impale on a random target
|
||||
//Do NOT cast it when we are afflicted by locust swarm
|
||||
if (!me->HasAura(RAID_MODE(SPELL_LOCUST_SWARM_10, SPELL_LOCUST_SWARM_25)))
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 0))
|
||||
DoCast(pTarget, RAID_MODE(SPELL_IMPALE_10, SPELL_IMPALE_25));
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0))
|
||||
DoCast(target, RAID_MODE(SPELL_IMPALE_10, SPELL_IMPALE_25));
|
||||
events.ScheduleEvent(EVENT_IMPALE, urand(10000, 20000));
|
||||
break;
|
||||
case EVENT_LOCUST:
|
||||
|
||||
@@ -361,8 +361,8 @@ public:
|
||||
|
||||
if (caster)
|
||||
{
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 0, 45.0f))
|
||||
DoCast(pTarget, SPELL_PRIMARY(id));
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0, 45.0f))
|
||||
DoCast(target, SPELL_PRIMARY(id));
|
||||
}
|
||||
else
|
||||
DoCast(me->getVictim(), SPELL_PRIMARY(id));
|
||||
|
||||
@@ -469,10 +469,10 @@ class boss_gothik : public CreatureScript
|
||||
DoTeleportTo(PosGroundLiveSide);
|
||||
|
||||
me->getThreatManager().resetAggro(NotOnSameSide(me));
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_NEAREST, 0))
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_NEAREST, 0))
|
||||
{
|
||||
me->getThreatManager().addThreat(pTarget, 100.0f);
|
||||
AttackStart(pTarget);
|
||||
me->getThreatManager().addThreat(target, 100.0f);
|
||||
AttackStart(target);
|
||||
}
|
||||
|
||||
events.ScheduleEvent(EVENT_TELEPORT, 20000);
|
||||
|
||||
@@ -59,11 +59,11 @@ public:
|
||||
events.ScheduleEvent(EVENT_BERSERK, 12*60000);
|
||||
}
|
||||
|
||||
void SpellHitTarget(Unit* pTarget, const SpellEntry *spell)
|
||||
void SpellHitTarget(Unit* target, const SpellEntry *spell)
|
||||
{
|
||||
if (spell->Id == uint32(SPELL_SLIME_SPRAY))
|
||||
{
|
||||
if (TempSummon *slime = me->SummonCreature(MOB_FALLOUT_SLIME, pTarget->GetPositionX(), pTarget->GetPositionY(), pTarget->GetPositionZ(), 0, TEMPSUMMON_TIMED_DESPAWN_OUT_OF_COMBAT, 0))
|
||||
if (TempSummon *slime = me->SummonCreature(MOB_FALLOUT_SLIME, target->GetPositionX(), target->GetPositionY(), target->GetPositionZ(), 0, TEMPSUMMON_TIMED_DESPAWN_OUT_OF_COMBAT, 0))
|
||||
DoZoneInCombat(slime);
|
||||
}
|
||||
}
|
||||
@@ -91,9 +91,9 @@ public:
|
||||
events.ScheduleEvent(EVENT_SPRAY, 15000+rand()%15000);
|
||||
return;
|
||||
case EVENT_INJECT:
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 1))
|
||||
if (!pTarget->HasAura(SPELL_MUTATING_INJECTION))
|
||||
DoCast(pTarget, SPELL_MUTATING_INJECTION);
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 1))
|
||||
if (!target->HasAura(SPELL_MUTATING_INJECTION))
|
||||
DoCast(target, SPELL_MUTATING_INJECTION);
|
||||
events.ScheduleEvent(EVENT_INJECT, 8000 + uint32(120 * me->GetHealthPct()));
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -498,13 +498,13 @@ public:
|
||||
uint32 count = urand(1, 3);
|
||||
for (uint8 i = 1; i <= count; i++)
|
||||
{
|
||||
Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 1, 200, true);
|
||||
if (pTarget && !pTarget->isCharmed() && (chained.find(pTarget->GetGUID()) == chained.end()))
|
||||
Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 1, 200, true);
|
||||
if (target && !target->isCharmed() && (chained.find(target->GetGUID()) == chained.end()))
|
||||
{
|
||||
DoCast(pTarget, SPELL_CHAINS_OF_KELTHUZAD);
|
||||
float scale = pTarget->GetFloatValue(OBJECT_FIELD_SCALE_X);
|
||||
chained.insert(std::make_pair(pTarget->GetGUID(), scale));
|
||||
pTarget->SetFloatValue(OBJECT_FIELD_SCALE_X, scale * 2);
|
||||
DoCast(target, SPELL_CHAINS_OF_KELTHUZAD);
|
||||
float scale = target->GetFloatValue(OBJECT_FIELD_SCALE_X);
|
||||
chained.insert(std::make_pair(target->GetGUID(), scale));
|
||||
target->SetFloatValue(OBJECT_FIELD_SCALE_X, scale * 2);
|
||||
events.ScheduleEvent(EVENT_CHAINED_SPELL, 2000); //core has 2000ms to set unit flag charm
|
||||
}
|
||||
}
|
||||
@@ -530,54 +530,54 @@ public:
|
||||
continue;
|
||||
}
|
||||
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_TOPAGGRO, 0, NotCharmedTargetSelector()))
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_TOPAGGRO, 0, NotCharmedTargetSelector()))
|
||||
{
|
||||
switch(player->getClass())
|
||||
{
|
||||
case CLASS_DRUID:
|
||||
if (urand(0, 1))
|
||||
player->CastSpell(pTarget, SPELL_MOONFIRE, false);
|
||||
player->CastSpell(target, SPELL_MOONFIRE, false);
|
||||
else
|
||||
player->CastSpell(me, SPELL_LIFEBLOOM, false);
|
||||
break;
|
||||
case CLASS_HUNTER:
|
||||
player->CastSpell(pTarget, RAND(SPELL_MULTI_SHOT, SPELL_VOLLEY), false);
|
||||
player->CastSpell(target, RAND(SPELL_MULTI_SHOT, SPELL_VOLLEY), false);
|
||||
break;
|
||||
case CLASS_MAGE:
|
||||
player->CastSpell(pTarget, RAND(SPELL_FROST_FIREBOLT, SPELL_ARCANE_MISSILES), false);
|
||||
player->CastSpell(target, RAND(SPELL_FROST_FIREBOLT, SPELL_ARCANE_MISSILES), false);
|
||||
break;
|
||||
case CLASS_WARLOCK:
|
||||
player->CastSpell(pTarget, RAND(SPELL_CURSE_OF_AGONY, SPELL_SHADOW_BOLT), true);
|
||||
player->CastSpell(target, RAND(SPELL_CURSE_OF_AGONY, SPELL_SHADOW_BOLT), true);
|
||||
break;
|
||||
case CLASS_WARRIOR:
|
||||
player->CastSpell(pTarget, RAND(SPELL_BLADESTORM, SPELL_CLEAVE), false);
|
||||
player->CastSpell(target, RAND(SPELL_BLADESTORM, SPELL_CLEAVE), false);
|
||||
break;
|
||||
case CLASS_PALADIN:
|
||||
if (urand(0, 1))
|
||||
player->CastSpell(pTarget, SPELL_HAMMER_OF_JUSTICE, false);
|
||||
player->CastSpell(target, SPELL_HAMMER_OF_JUSTICE, false);
|
||||
else
|
||||
player->CastSpell(me, SPELL_HOLY_SHOCK, false);
|
||||
break;
|
||||
case CLASS_PRIEST:
|
||||
if (urand(0, 1))
|
||||
player->CastSpell(pTarget, SPELL_VAMPIRIC_TOUCH, false);
|
||||
player->CastSpell(target, SPELL_VAMPIRIC_TOUCH, false);
|
||||
else
|
||||
player->CastSpell(me, SPELL_RENEW, false);
|
||||
break;
|
||||
case CLASS_SHAMAN:
|
||||
if (urand(0, 1))
|
||||
player->CastSpell(pTarget, SPELL_EARTH_SHOCK, false);
|
||||
player->CastSpell(target, SPELL_EARTH_SHOCK, false);
|
||||
else
|
||||
player->CastSpell(me, SPELL_HEALING_WAVE, false);
|
||||
break;
|
||||
case CLASS_ROGUE:
|
||||
player->CastSpell(pTarget, RAND(SPELL_HEMORRHAGE, SPELL_MUTILATE), false);
|
||||
player->CastSpell(target, RAND(SPELL_HEMORRHAGE, SPELL_MUTILATE), false);
|
||||
break;
|
||||
case CLASS_DEATH_KNIGHT:
|
||||
if (urand(0, 1))
|
||||
player->CastSpell(pTarget, SPELL_PLAGUE_STRIKE, true);
|
||||
player->CastSpell(target, SPELL_PLAGUE_STRIKE, true);
|
||||
else
|
||||
player->CastSpell(pTarget, SPELL_HOWLING_BLAST, true);
|
||||
player->CastSpell(target, SPELL_HOWLING_BLAST, true);
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -616,13 +616,13 @@ public:
|
||||
break;
|
||||
}
|
||||
case EVENT_FISSURE:
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 0))
|
||||
DoCast(pTarget, SPELL_SHADOW_FISURE);
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0))
|
||||
DoCast(target, SPELL_SHADOW_FISURE);
|
||||
events.RepeatEvent(urand(10000, 45000));
|
||||
break;
|
||||
case EVENT_BLAST:
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, RAID_MODE(1, 0), 0, true))
|
||||
DoCast(pTarget, SPELL_FROST_BLAST);
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, RAID_MODE(1, 0), 0, true))
|
||||
DoCast(target, SPELL_FROST_BLAST);
|
||||
if (rand()%2)
|
||||
DoScriptText(SAY_FROST_BLAST, me);
|
||||
events.RepeatEvent(urand(30000, 90000));
|
||||
|
||||
@@ -104,13 +104,13 @@ public:
|
||||
// TODO : Add missing text
|
||||
for (uint8 i = 0; i < RAID_MODE(1, 2); ++i)
|
||||
{
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 1, 0, true, -SPELL_WEB_WRAP))
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 1, 0, true, -SPELL_WEB_WRAP))
|
||||
{
|
||||
pTarget->RemoveAura(RAID_MODE(SPELL_WEB_SPRAY_10, SPELL_WEB_SPRAY_25));
|
||||
target->RemoveAura(RAID_MODE(SPELL_WEB_SPRAY_10, SPELL_WEB_SPRAY_25));
|
||||
uint8 pos = rand()%MAX_POS_WRAP;
|
||||
pTarget->GetMotionMaster()->MoveJump(PosWrap[pos].GetPositionX(), PosWrap[pos].GetPositionY(), PosWrap[pos].GetPositionZ(), 20, 20);
|
||||
target->GetMotionMaster()->MoveJump(PosWrap[pos].GetPositionX(), PosWrap[pos].GetPositionY(), PosWrap[pos].GetPositionZ(), 20, 20);
|
||||
if (Creature* wrap = DoSummon(MOB_WEB_WRAP, PosWrap[pos], 0, TEMPSUMMON_CORPSE_DESPAWN))
|
||||
wrap->AI()->SetGUID(pTarget->GetGUID());
|
||||
wrap->AI()->SetGUID(target->GetGUID());
|
||||
}
|
||||
}
|
||||
events.ScheduleEvent(EVENT_WRAP, 40000);
|
||||
|
||||
@@ -118,11 +118,11 @@ public:
|
||||
std::list<HostileReference*>::const_iterator i = me->getThreatManager().getThreatList().begin();
|
||||
for (; i != me->getThreatManager().getThreatList().end(); ++i)
|
||||
{
|
||||
Unit* pTarget = (*i)->getTarget();
|
||||
if (pTarget->isAlive() && pTarget != me->getVictim() && pTarget->GetHealth() > MostHP && me->IsWithinMeleeRange(pTarget))
|
||||
Unit* target = (*i)->getTarget();
|
||||
if (target->isAlive() && target != me->getVictim() && target->GetHealth() > MostHP && me->IsWithinMeleeRange(target))
|
||||
{
|
||||
MostHP = pTarget->GetHealth();
|
||||
pMostHPTarget = pTarget;
|
||||
MostHP = target->GetHealth();
|
||||
pMostHPTarget = target;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -118,8 +118,8 @@ public:
|
||||
events.ScheduleEvent(EVENT_SHOUT, 25000);
|
||||
return;
|
||||
case EVENT_KNIFE:
|
||||
if (Unit* pTarget = SelectTarget(SELECT_TARGET_RANDOM, 0, 45.0f))
|
||||
DoCast(pTarget, SPELL_JAGGED_KNIFE);
|
||||
if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0, 45.0f))
|
||||
DoCast(target, SPELL_JAGGED_KNIFE);
|
||||
events.ScheduleEvent(EVENT_KNIFE, 10000);
|
||||
return;
|
||||
case EVENT_COMMAND:
|
||||
|
||||
@@ -132,14 +132,14 @@ public:
|
||||
CheckPlayersFrostResist();
|
||||
}
|
||||
|
||||
void SpellHitTarget(Unit* pTarget, const SpellEntry *spell)
|
||||
void SpellHitTarget(Unit* target, const SpellEntry *spell)
|
||||
{
|
||||
if (spell->Id == SPELL_ICEBOLT)
|
||||
{
|
||||
IceBlockMap::iterator itr = iceblocks.find(pTarget->GetGUID());
|
||||
IceBlockMap::iterator itr = iceblocks.find(target->GetGUID());
|
||||
if (itr != iceblocks.end() && !itr->second)
|
||||
{
|
||||
if (GameObject* iceblock = me->SummonGameObject(GO_ICEBLOCK, pTarget->GetPositionX(), pTarget->GetPositionY(), pTarget->GetPositionZ(), 0, 0, 0, 0, 0, 25000))
|
||||
if (GameObject* iceblock = me->SummonGameObject(GO_ICEBLOCK, target->GetPositionX(), target->GetPositionY(), target->GetPositionZ(), 0, 0, 0, 0, 0, 25000))
|
||||
itr->second = iceblock->GetGUID();
|
||||
}
|
||||
}
|
||||
@@ -360,14 +360,14 @@ public:
|
||||
std::list<HostileReference*>::const_iterator i = me->getThreatManager().getThreatList().begin();
|
||||
for (; i != me->getThreatManager().getThreatList().end(); ++i)
|
||||
{
|
||||
Unit* pTarget = (*i)->getTarget();
|
||||
if (pTarget->GetTypeId() != TYPEID_PLAYER)
|
||||
Unit* target = (*i)->getTarget();
|
||||
if (target->GetTypeId() != TYPEID_PLAYER)
|
||||
continue;
|
||||
|
||||
if (pTarget->HasAura(SPELL_ICEBOLT))
|
||||
if (target->HasAura(SPELL_ICEBOLT))
|
||||
{
|
||||
pTarget->ApplySpellImmune(0, IMMUNITY_ID, SPELL_FROST_EXPLOSION, true);
|
||||
targets.push_back(pTarget);
|
||||
target->ApplySpellImmune(0, IMMUNITY_ID, SPELL_FROST_EXPLOSION, true);
|
||||
targets.push_back(target);
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -375,11 +375,11 @@ public:
|
||||
{
|
||||
if (GameObject* pGo = GameObject::GetGameObject(*me, itr->second))
|
||||
{
|
||||
if (pGo->IsInBetween(me, pTarget, 2.0f)
|
||||
&& me->GetExactDist2d(pTarget->GetPositionX(), pTarget->GetPositionY()) - me->GetExactDist2d(pGo->GetPositionX(), pGo->GetPositionY()) < 5.0f)
|
||||
if (pGo->IsInBetween(me, target, 2.0f)
|
||||
&& me->GetExactDist2d(target->GetPositionX(), target->GetPositionY()) - me->GetExactDist2d(pGo->GetPositionX(), pGo->GetPositionY()) < 5.0f)
|
||||
{
|
||||
pTarget->ApplySpellImmune(0, IMMUNITY_ID, SPELL_FROST_EXPLOSION, true);
|
||||
targets.push_back(pTarget);
|
||||
target->ApplySpellImmune(0, IMMUNITY_ID, SPELL_FROST_EXPLOSION, true);
|
||||
targets.push_back(target);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user