josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Player: Prevented infinite growth of allowedCharsToLogin container and changed its type to better reflect its purpose

Browse Source
This commit is contained in:
Shauren
2011-04-04 22:27:15 +02:00
parent 804953911e
commit 379308140b
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/game/Server/Protocol/Handlers/CharacterHandler.cpp
+2 -1
View File
@@ -205,6 +205,7 @@ void WorldSession::HandleCharEnum(QueryResult result)
data << num; data << num;
_allowedCharsToLogin.clear();
if (result) if (result)
{ {
do do
@@ -213,7 +214,7 @@ void WorldSession::HandleCharEnum(QueryResult result)
sLog->outDetail("Loading char guid %u from account %u.",guidlow,GetAccountId()); sLog->outDetail("Loading char guid %u from account %u.",guidlow,GetAccountId());
if (Player::BuildEnumData(result, &data)) if (Player::BuildEnumData(result, &data))
{ {
m_AllowedCharsToLogin.push_back(guidlow); _allowedCharsToLogin.insert(guidlow);
++num; ++num;
} }
} }
src/server/game/Server/WorldSession.h
+3 -7
View File
@@ -883,17 +883,13 @@ class WorldSession
void LogUnprocessedTail(WorldPacket *packet); void LogUnprocessedTail(WorldPacket *packet);
// EnumData helpers // EnumData helpers
bool CharCanLogin(uint32 LowGUID) bool CharCanLogin(uint32 lowGUID)
{ {
if (find(m_AllowedCharsToLogin.begin(), return _allowedCharsToLogin.find(lowGUID) != _allowedCharsToLogin.end();
m_AllowedCharsToLogin.end(),
LowGUID) == m_AllowedCharsToLogin.end())
return false;
return true;
} }
// this stores the GUIDs of the characters who can login // this stores the GUIDs of the characters who can login
// characters who failed on Player::BuildEnumData shouldn't login // characters who failed on Player::BuildEnumData shouldn't login
std::list<uint32> m_AllowedCharsToLogin; std::set<uint32> _allowedCharsToLogin;
uint32 m_GUIDLow; // set loggined or recently logout player (while m_playerRecentlyLogout set) uint32 m_GUIDLow; // set loggined or recently logout player (while m_playerRecentlyLogout set)
Player *_player; Player *_player;