Scripts/VH: Add an 1 minute pause after each boss fight (instead of 5 seconds)

Revert one of the warning fixes (non standard C++)

src/server/game/Spells/SpellInfo.cpp

@@ -351,7 +351,7 @@ bool SpellEffectInfo::IsEffect() const
 
 bool SpellEffectInfo::IsEffect(SpellEffects effectName) const
 {
-    return Effect == effectName;
+    return Effect == uint32(effectName);
 }
 
 bool SpellEffectInfo::IsAura() const

src/server/scripts/Northrend/VioletHold/instance_violet_hold.cpp

@@ -690,7 +690,8 @@ public:
                 {
                     AddWave();
                     bActive = false;
-                    uiActivationTimer = 5000;
+                    // 1 minute waiting time after each boss fight
+                    uiActivationTimer = (uiWaveCount == 6 || uiWaveCount == 12) ? 60000 : 5000;
                 } else uiActivationTimer -= diff;
             }
 

src/tools/map_extractor/adt.cpp

@@ -53,7 +53,7 @@ bool ADT_file::prepareLoadedData()
 
 bool adt_MHDR::prepareLoadedData()
 {
-    if (fcc != "MHDR")
+    if (fcc != 'MHDR')
         return false;
 
     if (size!=sizeof(adt_MHDR)-8)
@@ -72,7 +72,7 @@ bool adt_MHDR::prepareLoadedData()
 
 bool adt_MCIN::prepareLoadedData()
 {
-    if (fcc != "MCIN")
+    if (fcc != 'MCIN')
         return false;
 
     // Check cells data
@@ -86,7 +86,7 @@ bool adt_MCIN::prepareLoadedData()
 
 bool adt_MH2O::prepareLoadedData()
 {
-    if (fcc != "MH2O")
+    if (fcc != 'MH2O')
         return false;
 
     // Check liquid data
@@ -98,7 +98,7 @@ bool adt_MH2O::prepareLoadedData()
 
 bool adt_MCNK::prepareLoadedData()
 {
-    if (fcc != "MCNK")
+    if (fcc != 'MCNK')
         return false;
 
     // Check height map
@@ -113,7 +113,7 @@ bool adt_MCNK::prepareLoadedData()
 
 bool adt_MCVT::prepareLoadedData()
 {
-    if (fcc != "MCVT")
+    if (fcc != 'MCVT')
         return false;
 
     if (size != sizeof(adt_MCVT)-8)
@@ -124,7 +124,7 @@ bool adt_MCVT::prepareLoadedData()
 
 bool adt_MCLQ::prepareLoadedData()
 {
-    if (fcc != "MCLQ")
+    if (fcc != 'MCLQ')
         return false;
 
     return true;

src/tools/map_extractor/loadlib.cpp

@@ -49,7 +49,7 @@ bool FileLoader::prepareLoadedData()
 {
     // Check version
     version = (file_MVER *) data;
-    if (version->fcc != "MVER")
+    if (version->fcc != 'MVER')
         return false;
     if (version->ver != FILE_FORMAT_VERSION)
         return false;

src/tools/map_extractor/wdt.cpp

@@ -4,21 +4,21 @@
 
 bool wdt_MWMO::prepareLoadedData()
 {
-    if (fcc != "MWMO")
+    if (fcc != 'MWMO')
         return false;
     return true;
 }
 
 bool wdt_MPHD::prepareLoadedData()
 {
-    if (fcc != "MPHD")
+    if (fcc != 'MPHD')
         return false;
     return true;
 }
 
 bool wdt_MAIN::prepareLoadedData()
 {
-    if (fcc != "MAIN")
+    if (fcc != 'MAIN')
         return false;
     return true;
 }