Core/Achievements: Fixed achievements with ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA requiring one extra win to complete, PersonalRating was not used here and has been removed from the call, related to issue #2021
Signed-off-by: Subv2112 <[email protected]>
This commit is contained in:
@@ -1179,7 +1179,6 @@ void AchievementMgr::UpdateAchievementCriteria(AchievementCriteriaTypes type, ui
|
||||
SetCriteriaProgress(achievementCriteria, miscValue2, PROGRESS_ACCUMULATE);
|
||||
break;
|
||||
case ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA:
|
||||
// miscvalue1 contains the personal rating
|
||||
if (!miscValue1) // no update at login
|
||||
continue;
|
||||
|
||||
|
||||
@@ -824,7 +824,7 @@ void Battleground::EndBattleground(uint32 winner)
|
||||
// update achievement BEFORE personal rating update
|
||||
ArenaTeamMember* member = winner_arena_team->GetMember(player->GetGUID());
|
||||
if (member)
|
||||
player->GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA, member->PersonalRating);
|
||||
player->GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA, 1);
|
||||
|
||||
winner_arena_team->MemberWon(player, loser_matchmaker_rating, winner_matchmaker_change);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user