josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Achievements: Fixed achievements with ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA requiring one extra win to complete, PersonalRating was not used here and has been removed from the call, related to issue #2021

Browse Source 
Signed-off-by: Subv2112 <[email protected]>
This commit is contained in:
Subv2112
2012-01-31 16:33:21 -05:00
parent bdae78ac9d
commit 229b97806a
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/game/Achievements/AchievementMgr.cpp
-1
View File
@@ -1179,7 +1179,6 @@ void AchievementMgr::UpdateAchievementCriteria(AchievementCriteriaTypes type, ui
SetCriteriaProgress(achievementCriteria, miscValue2, PROGRESS_ACCUMULATE); SetCriteriaProgress(achievementCriteria, miscValue2, PROGRESS_ACCUMULATE);
break; break;
case ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA: case ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA:
// miscvalue1 contains the personal rating
if (!miscValue1) // no update at login if (!miscValue1) // no update at login
continue; continue;
src/server/game/Battlegrounds/Battleground.cpp
+1 -1
View File
@@ -824,7 +824,7 @@ void Battleground::EndBattleground(uint32 winner)
// update achievement BEFORE personal rating update // update achievement BEFORE personal rating update
ArenaTeamMember* member = winner_arena_team->GetMember(player->GetGUID()); ArenaTeamMember* member = winner_arena_team->GetMember(player->GetGUID());
if (member) if (member)
player->GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA, member->PersonalRating); player->GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_WIN_RATED_ARENA, 1);
winner_arena_team->MemberWon(player, loser_matchmaker_rating, winner_matchmaker_change); winner_arena_team->MemberWon(player, loser_matchmaker_rating, winner_matchmaker_change);
} }