josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

*Fix logical error in Player::LoadFromDB regarding dual speccing, and relocate code for consistency

Browse Source 
--HG--
branch : trunk
This commit is contained in:
Machiavelli
2009-08-15 17:05:34 +02:00
parent 230d112282
commit 2057f7d01d
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/game/Player.cpp
+10 -7
View File
@@ -14644,13 +14644,6 @@ bool Player::LoadFromDB( uint32 guid, SqlQueryHolder *holder )
return false; return false;
} }
m_specsCount = fields[42].GetUInt32();
m_activeSpec = fields[43].GetUInt32();
// sanity check
if (m_specsCount < 2) // Maybe better to check MAX_TALENT_SPECS?
m_activeSpec = 0;
Object::_Create( guid, 0, HIGHGUID_PLAYER ); Object::_Create( guid, 0, HIGHGUID_PLAYER );
m_name = fields[3].GetCppString(); m_name = fields[3].GetCppString();
@@ -15070,7 +15063,17 @@ bool Player::LoadFromDB( uint32 guid, SqlQueryHolder *holder )
//mails are loaded only when needed ;-) - when player in game click on mailbox. //mails are loaded only when needed ;-) - when player in game click on mailbox.
//_LoadMail(); //_LoadMail();
m_specsCount = fields[42].GetUInt32();
m_activeSpec = fields[43].GetUInt32();
// sanity check
if (m_specsCount > MAX_TALENT_SPECS || m_activeSpec > MAX_TALENT_SPECS) // if (m_specsCount < 2) is not logical
{
m_activeSpec = 0;
sLog.outError("Player %s(GUID: %u) has SpecCount = %u and ActiveSpec = %u.", GetName(), GetGUIDLow(), m_specsCount, m_activeSpec);
}
_LoadTalents(holder->GetResult(PLAYER_LOGIN_QUERY_LOADTALENTS)); _LoadTalents(holder->GetResult(PLAYER_LOGIN_QUERY_LOADTALENTS));
_LoadSpells(holder->GetResult(PLAYER_LOGIN_QUERY_LOADSPELLS)); _LoadSpells(holder->GetResult(PLAYER_LOGIN_QUERY_LOADSPELLS));