[7370] Fixed crash in CheckSkirmishForSameFaction() function, when we erased iterator which shouldn't be erased

Fixed crash in BattleGroundQueue::Update() by changing BGFreeSlotQueueType from deque to list. Author: Triply

--HG--
branch : trunk

src/game/BattleGroundMgr.h

@@ -26,7 +26,8 @@
 
 typedef std::map<uint32, BattleGround*> BattleGroundSet;
 
-typedef std::deque<BattleGround*> BGFreeSlotQueueType;
+//this container can't be deque, because deque doesn't like removing the last element - if you remove it, it invalidates next iterator and crash appears
+typedef std::list<BattleGround*> BGFreeSlotQueueType;
 
 typedef UNORDERED_MAP<uint32, BattleGroundTypeId> BattleMastersMap;