josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SPELLMOD_PCT spell mods to stack in a truly multiplicative way

Browse Source 
--HG--
branch : trunk
This commit is contained in:
Xanadu
2010-01-21 02:02:35 +01:00
parent 9e91fc997c
commit 01bb79cc7d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/game/Player.h
+3 -3
View File
@@ -2590,7 +2590,7 @@ template <class T> T Player::ApplySpellMod(uint32 spellId, SpellModOp op, T &bas
{ {
SpellEntry const *spellInfo = sSpellStore.LookupEntry(spellId); SpellEntry const *spellInfo = sSpellStore.LookupEntry(spellId);
if (!spellInfo) return 0; if (!spellInfo) return 0;
int32 totalpct = 0; float totalmul = 1.0f;
int32 totalflat = 0; int32 totalflat = 0;
// Drop charges for triggering spells instead of triggered ones // Drop charges for triggering spells instead of triggered ones
@@ -2620,12 +2620,12 @@ template <class T> T Player::ApplySpellMod(uint32 spellId, SpellModOp op, T &bas
if( mod->op==SPELLMOD_CASTING_TIME && basevalue >= T(10000) && mod->value <= -100) if( mod->op==SPELLMOD_CASTING_TIME && basevalue >= T(10000) && mod->value <= -100)
continue; continue;
totalpct += mod->value; totalmul *= 1.0f + (float)mod->value / 100.0f;
} }
DropModCharge(mod, spell); DropModCharge(mod, spell);
} }
float diff = (float)basevalue*(float)totalpct/100.0f + (float)totalflat; float diff = (float)basevalue * (totalmul - 1.0f) + (float)totalflat;
basevalue = T((float)basevalue + diff); basevalue = T((float)basevalue + diff);
return T(diff); return T(diff);
} }